Skip to content

Conversation

@MrPresent-Han
Copy link
Contributor

related: #41675

@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jan 15, 2026
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jan 15, 2026
@MrPresent-Han MrPresent-Han force-pushed the support-search-orderby-master branch from 32702e3 to 08af4ec Compare January 15, 2026 07:43
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 2.15664% with 1724 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.03%. Comparing base (9373518) to head (08af4ec).
⚠️ Report is 11 commits behind head on master.

⚠️ Current head 08af4ec differs from pull request most recent head b75dabd

Please upload reports for the commit b75dabd to get more accurate results.

Files with missing lines Patch % Lines
internal/proxy/search_reduce_util.go 3.77% 532 Missing and 4 partials ⚠️
internal/querynodev2/segments/search_reduce.go 0.84% 348 Missing and 3 partials ⚠️
.../operator/search-orderby/SearchOrderByOperator.cpp 0.00% 217 Missing ⚠️
...re/src/segcore/reduce/GroupOrderByReduceHelper.cpp 0.00% 181 Missing ⚠️
internal/querynodev2/segments/result.go 0.00% 148 Missing ⚠️
...al/core/src/segcore/reduce/OrderByReduceHelper.cpp 0.00% 123 Missing ⚠️
internal/core/src/segcore/ReduceStructure.cpp 0.00% 39 Missing ⚠️
...ernal/core/src/exec/operator/SearchOrderByNode.cpp 0.00% 38 Missing ⚠️
internal/core/src/segcore/ReduceStructure.h 13.79% 25 Missing ⚠️
internal/core/src/query/PlanProto.cpp 10.52% 17 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #47091      +/-   ##
==========================================
- Coverage   76.46%   76.03%   -0.44%     
==========================================
  Files        2016     2025       +9     
  Lines      325600   327944    +2344     
==========================================
+ Hits       248972   249346     +374     
- Misses      68670    70605    +1935     
- Partials     7958     7993      +35     
Components Coverage Δ
Client 75.68% <ø> (ø)
Core 82.35% <36.41%> (-0.54%) ⬇️
Go 74.41% <13.08%> (-0.42%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/QueryInfo.h 100.00% <ø> (ø)
internal/core/src/plan/OrderByField.h 0.00% <0.00%> (ø)
internal/util/reduce/reduce_info.go 84.48% <40.00%> (-4.20%) ⬇️
...core/src/segcore/reduce/GroupOrderByReduceHelper.h 0.00% <0.00%> (ø)
internal/core/src/segcore/reduce_c.cpp 79.43% <50.00%> (-3.90%) ⬇️
...rnal/core/src/segcore/reduce/OrderByReduceHelper.h 0.00% <0.00%> (ø)
...nternal/core/src/exec/operator/SearchOrderByNode.h 0.00% <0.00%> (ø)
internal/core/src/plan/PlanNode.h 58.29% <0.00%> (-4.42%) ⬇️
internal/core/src/query/PlanProto.cpp 64.90% <10.52%> (-1.71%) ⬇️
internal/core/src/segcore/ReduceStructure.h 56.89% <13.79%> (-43.11%) ⬇️
... and 8 more

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrPresent-Han MrPresent-Han force-pushed the support-search-orderby-master branch from 08af4ec to 30db980 Compare January 15, 2026 09:47
@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2026

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-search-orderby-master branch from 30db980 to b75dabd Compare January 16, 2026 02:16
@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2026

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Jan 16, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 16, 2026

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Issues related to feature request from users needs-dco DCO is missing in this pull request. size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants