Skip to content

Conversation

@xiaofan-luan
Copy link
Collaborator

@xiaofan-luan xiaofan-luan commented Jan 15, 2026

issue #47025

  • Consolidate MATCH_ALL/MATCH_ANY into MatchSimple rule and MATCH_LEAST/MATCH_MOST/MATCH_EXACT into MatchThreshold rule
  • Consolidate spatial functions (STEquals, STTouches, etc.) into single SpatialBinary rule
  • Simplify visitor implementation to handle consolidated grammar rules
  • Add comprehensive benchmark tests for parser performance
  • Add optimization comparison tests to validate changes]

@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. labels Jan 15, 2026
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 15, 2026
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm
  • /ci-rerun-e2e-default // for ci-v2/e2e-default

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 72.28261% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.49%. Comparing base (2572770) to head (c253116).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/parser/planparserv2/parser_visitor.go 67.09% 49 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (72.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (76.49%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #47092      +/-   ##
==========================================
- Coverage   76.56%   76.49%   -0.07%     
==========================================
  Files        2016     2016              
  Lines      326928   326127     -801     
==========================================
- Hits       250316   249483     -833     
- Misses      68652    68670      +18     
- Partials     7960     7974      +14     
Components Coverage Δ
Client 75.68% <ø> (ø)
Core 82.95% <ø> (ø)
Go 74.86% <72.28%> (-0.11%) ⬇️
Files with missing lines Coverage Δ
internal/parser/planparserv2/pool.go 100.00% <100.00%> (+10.71%) ⬆️
internal/parser/planparserv2/utils.go 96.14% <100.00%> (+9.01%) ⬆️
internal/parser/planparserv2/parser_visitor.go 86.60% <67.09%> (+6.67%) ⬆️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…nd adding benchmarks

- Consolidate MATCH_ALL/MATCH_ANY into MatchSimple rule and MATCH_LEAST/MATCH_MOST/MATCH_EXACT into MatchThreshold rule
- Consolidate spatial functions (STEquals, STTouches, etc.) into single SpatialBinary rule
- Simplify visitor implementation to handle consolidated grammar rules
- Add comprehensive benchmark tests for parser performance
- Add optimization comparison tests to validate changes

Signed-off-by: xiaofanluan <[email protected]>
@xiaofan-luan xiaofan-luan force-pushed the optimized-parser-to-improve-pa-8252 branch from e1733bd to c253116 Compare January 15, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants