-
Notifications
You must be signed in to change notification settings - Fork 3.8k
enhance: optimize planparser grammar by consolidating similar rules and adding benchmarks #47092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
enhance: optimize planparser grammar by consolidating similar rules and adding benchmarks #47092
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (72.28%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #47092 +/- ##
==========================================
- Coverage 76.56% 76.49% -0.07%
==========================================
Files 2016 2016
Lines 326928 326127 -801
==========================================
- Hits 250316 249483 -833
- Misses 68652 68670 +18
- Partials 7960 7974 +14
🚀 New features to boost your workflow:
|
…nd adding benchmarks - Consolidate MATCH_ALL/MATCH_ANY into MatchSimple rule and MATCH_LEAST/MATCH_MOST/MATCH_EXACT into MatchThreshold rule - Consolidate spatial functions (STEquals, STTouches, etc.) into single SpatialBinary rule - Simplify visitor implementation to handle consolidated grammar rules - Add comprehensive benchmark tests for parser performance - Add optimization comparison tests to validate changes Signed-off-by: xiaofanluan <[email protected]>
e1733bd to
c253116
Compare
issue #47025