enhance: Add target manager to ReplicaObserver initialization

[sunby]

issue: #47072
pr: #47094

[gemini-code-assist]

Summary of Changes

Hello @sunby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a TargetManagerInterface into the ReplicaObserver component during its creation. This modification ensures that the observer has the necessary access to target management capabilities, which is essential for its operational logic. The changes propagate through the system's initialization routines and corresponding test setups to accommodate this new dependency.

Highlights

• Dependency Injection: The ReplicaObserver now accepts a targetMgr (of type meta.TargetManagerInterface) during its initialization, allowing it to utilize target management functionalities.
• Structural Update: The ReplicaObserver struct has been updated to include a targetMgr field to store the newly injected dependency.
• Initialization Updates: All points where ReplicaObserver is instantiated, including in server.go and various test files, have been updated to provide the targetMgr.
• Testing Enhancements: Test suites related to ReplicaObserver have been modified to include and mock the TargetManager to ensure proper testing of the updated constructor.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• internal/querycoordv2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mergify]

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

[sre-ci-robot]

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

• /ci-rerun-code-check // for ci-v2/code-check
• /ci-rerun-build // for ci-v2/build
• /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
• /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
• /ci-rerun-ut-cpp // for ci-v2/ut-cpp
• /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
• /ci-rerun-e2e-arm // for ci-v2/e2e-arm
• /ci-rerun-e2e-default // for ci-v2/e2e-default

If you have any questions or requests, please contact @zhikunyao.

[sre-ci-robot]

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

• Target branch '2.6' requires a PR merged to master first
• Please add reference in format 'pr: #number'

[WARNING] Milestone not set

• PR: enhance: Add target manager to ReplicaObserver initialization #47093
• Title: enhance: Add target manager to ReplicaObserver initialization
  Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[gemini-code-assist]

Code Review

This pull request correctly adds the targetMgr dependency to the ReplicaObserver initialization. The changes are straightforward and have been consistently applied across the main application logic and the corresponding test files. The dependency injection is properly handled, ensuring that the targetMgr is available where needed. The code modifications are clean and follow existing patterns. I don't see any issues with the proposed changes.

[mergify]

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.25%. Comparing base (cb08db0) to head (e102c13).
⚠️ Report is 553 commits behind head on 2.6.

Additional details and impacted files

@@             Coverage Diff             @@
##              2.6   #47093       +/-   ##
===========================================
- Coverage   76.99%   41.25%   -35.74%     
===========================================
  Files        1700     1207      -493     
  Lines      262533   188985    -73548     
===========================================
- Hits       202142    77971   -124171     
- Misses      53550   110682    +57132     
+ Partials     6841      332     -6509     

Components	Coverage Δ
Client	∅ <ø> (∅)
Core	83.65% <79.25%> (+1.44%)	⬆️
Go	9.58% <4.16%> (-65.81%)	⬇️
see 1395 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.