enhance: [2.6] Prevent import job or task rolling back state

[bigsheeper]

issue: #47099

pr: #47100

[gemini-code-assist]

Summary of Changes

Hello @bigsheeper, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the stability of the import functionality by introducing safeguards that prevent the state of import jobs and tasks from being updated after they have reached a terminal Completed or Failed status. This ensures that the final outcome of an import operation is preserved and not inadvertently overwritten, improving the reliability of the system's metadata management.

Highlights

• Import Job State Protection: Introduced checks in the UpdateJob function to prevent any further state changes once an import job has reached a Completed or Failed state, ensuring its final status is immutable.
• Import Task State Protection: Implemented similar checks in the UpdateTask function to ensure that individual import tasks, once Completed or Failed, cannot have their states modified by subsequent updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• internal/datacoord/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sre-ci-robot]

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

• /ci-rerun-code-check // for ci-v2/code-check
• /ci-rerun-build // for ci-v2/build
• /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
• /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
• /ci-rerun-ut-cpp // for ci-v2/ut-cpp
• /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
• /ci-rerun-e2e-arm // for ci-v2/e2e-arm
• /ci-rerun-e2e-default // for ci-v2/e2e-default

If you have any questions or requests, please contact @zhikunyao.

[sre-ci-robot]

[INFO] PR Label Summary by Default
[FAILED] PR #47100 not merged

• Title: enhance: Prevent import job or task rolling back state
• Status: OPEN
• Link: enhance: Prevent import job or task rolling back state #47100

[WARNING] Milestone not set

• PR: enhance: [2.6] Prevent import job or task rolling back state #47102
• Title: enhance: [2.6] Prevent import job or task rolling back state
  Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[gemini-code-assist]

Code Review

This pull request enhances the import mechanism by preventing state rollbacks for jobs and tasks that have already reached a terminal state (Completed or Failed). The changes in UpdateJob and UpdateTask correctly implement this by adding checks and returning early. My feedback includes a couple of suggestions to improve code style and maintainability by using switch statements for state checks.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.68%. Comparing base (cb08db0) to head (1fc01e6).
⚠️ Report is 555 commits behind head on 2.6.

⚠️ Current head 1fc01e6 differs from pull request most recent head 7103ef4

Please upload reports for the commit 7103ef4 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##              2.6   #47102       +/-   ##
===========================================
+ Coverage   76.99%   81.68%    +4.69%     
===========================================
  Files        1700      537     -1163     
  Lines      262533    84246   -178287     
===========================================
- Hits       202142    68819   -133323     
+ Misses      53550    15375    -38175     
+ Partials     6841       52     -6789     

Components	Coverage Δ
Client	∅ <ø> (∅)
Core	82.58% <80.62%> (+0.37%)	⬆️
Go	∅ <ø> (∅)
see 1526 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sre-ci-robot]

[INFO] PR Label Summary by Default
[FAILED] PR #47100 not merged

• Title: enhance: Prevent import job or task rolling back state
• Status: OPEN
• Link: enhance: Prevent import job or task rolling back state #47100

[WARNING] Milestone not set

• PR: enhance: [2.6] Prevent import job or task rolling back state #47102
• Title: enhance: [2.6] Prevent import job or task rolling back state
  Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

[sre-ci-robot]

[INFO] PR Label Summary by Default
[FAILED] PR #47100 not merged

• Title: enhance: Prevent import job or task rolling back state
• Status: OPEN
• Link: enhance: Prevent import job or task rolling back state #47100

[WARNING] Milestone not set

• PR: enhance: [2.6] Prevent import job or task rolling back state #47102
• Title: enhance: [2.6] Prevent import job or task rolling back state
  Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually