enhance: [2.6] update knowhere version #47109
Conversation
Signed-off-by: chasingegg <[email protected]>
Summary of ChangesHello @chasingegg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the version of the Knowhere dependency within the project's build configuration. This update ensures that the project utilizes the latest iteration of the Knowhere library, likely bringing in recent enhancements or fixes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chasingegg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@chasingegg Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #") |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
sre-ci-robot
added
do-not-merge/need-merge-master-first
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the version of the knowhere dependency to v2.6.10. The change is straightforward. I've added one suggestion to improve the style and consistency of the set command in the CMakeLists.txt file, which will also make it more robust.
| milvus_add_pkg_config("knowhere") | ||
| set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "") | ||
| set( KNOWHERE_VERSION v2.6.9 ) | ||
| set( KNOWHERE_VERSION v2.6.10 ) |
There was a problem hiding this comment.
For consistency and improved readability, it's good practice to remove the spaces inside the set command's parentheses and to quote string literal values. This also makes the code more robust if the value were to contain spaces in the future.
set(KNOWHERE_VERSION "v2.6.10")
mergify
bot
added
kind/enhancement
chasingegg
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.6 #47109 +/- ##
==========================================
+ Coverage 74.51% 76.73% +2.21%
==========================================
Files 1395 1920 +525
Lines 217980 300333 +82353
==========================================
+ Hits 162428 230446 +68018
- Misses 48124 62463 +14339
+ Partials 7428 7424 -4
🚀 New features to boost your workflow:
|
Signed-off-by: chasingegg <[email protected]>
|
[INFO] PR Label Summary by Default
[WARNING] Milestone not set
You can set milestone by commenting: Use /refresh-label to update related check and label manually |
2 participants
issue: #42937
/kind branch-feature