enhance: [2.6] adds dimensions support for TEI text embedding. by melodyshu · Pull Request #49646 · milvus-io/milvus

melodyshu · 2026-05-09T08:48:52Z

Changes:

Parse Function param "dim" in TEI embedding provider.
Pass it to TEI /embed request as JSON field "dimensions".
Keep existing behavior when dim is not specified.
Add unit tests for request serialization and provider dim parsing.

Tests:

go test ./internal/util/function/models/tei -count=1 -v
go test -tags test ./internal/util/function/embedding -run TestTEITextEmbeddingProvider -count=1 -v

issue: milvus-io#49644 Changes: - Parse Function param "dim" in TEI embedding provider. - Pass it to TEI /embed request as JSON field "dimensions". - Keep existing behavior when dim is not specified. - Add unit tests for request serialization and provider dim parsing. Tests: - go test ./internal/util/function/models/tei -count=1 -v - go test -tags test ./internal/util/function/embedding -run TestTEITextEmbeddingProvider -count=1 -v Signed-off-by: melodyshu <1321497435@qq.com>

sre-ci-robot · 2026-05-09T08:49:01Z

Welcome @melodyshu! It looks like this is your first PR to milvus-io/milvus 🎉

sre-ci-robot · 2026-05-09T08:49:04Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: melodyshu
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2026-05-09T08:49:29Z

@melodyshu Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

sre-ci-robot · 2026-05-09T08:49:48Z

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

Target branch '2.6' requires a PR merged to master first
Please add reference in format 'pr: #number'

[WARNING] Milestone not set

PR: enhance: [2.6] adds dimensions support for TEI text embedding. #49646
Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot · 2026-05-09T08:50:03Z

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-build // for ci-v2/build
/ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
/ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
/ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
/ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
/ci-rerun-e2e-default // for ci-v2/e2e-default
/ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
/ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
/ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

melodyshu · 2026-05-09T09:08:20Z

Done. Added the related master PR to the PR body.

codecov · 2026-05-09T09:38:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.39%. Comparing base (7a9e8e4) to head (6bdaa9e).
⚠️ Report is 42 commits behind head on 2.6.

Additional details and impacted files

@@            Coverage Diff             @@
##              2.6   #49646      +/-   ##
==========================================
- Coverage   77.40%   77.39%   -0.01%     
==========================================
  Files        1974     1974              
  Lines      315088   315099      +11     
==========================================
- Hits       243883   243867      -16     
- Misses      63633    63650      +17     
- Partials     7572     7582      +10

Components	Coverage Δ
Client	`81.03% <ø> (ø)`
Core	`83.92% <ø> (ø)`
Go	`75.73% <100.00%> (-0.02%)`	⬇️

Files with missing lines	Coverage Δ
.../util/function/embedding/tei_embedding_provider.go	`87.23% <100.00%> (+1.18%)`	⬆️
internal/util/function/models/tei/tei.go	`85.71% <100.00%> (+0.52%)`	⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

melodyshu · 2026-05-09T10:51:08Z

/refresh-label

sre-ci-robot · 2026-05-09T10:51:52Z

[INFO] PR Label Summary by Refresh-Label

Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Target: 2.6
Labels: kind/enhancement, size/M, dco-passed, do-not-merge/need-merge-master-first, do-not-merge/need-milestone

[FAILED] PR #49654 not merged

Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Status: OPEN
Link: enhance: [2.6] adds dimensions support for TEI text embedding. #49654

[WARNING] Milestone not set

PR: enhance: [2.6] adds dimensions support for TEI text embedding. #49646
Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

melodyshu · 2026-05-09T10:54:20Z

/set-milestone 2.6.16

sre-ci-robot · 2026-05-09T10:54:54Z

[INFO] Set milestone to: 2.6.16

melodyshu · 2026-05-09T10:56:04Z

/refresh-label

sre-ci-robot · 2026-05-09T10:56:34Z

[INFO] PR Label Summary by Refresh-Label

Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Target: 2.6
Labels: kind/enhancement, size/M, dco-passed, do-not-merge/need-merge-master-first

[FAILED] PR #49654 not merged

Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Status: OPEN
Link: enhance: [2.6] adds dimensions support for TEI text embedding. #49654

Use /refresh-label to update related check and label manually

sre-ci-robot · 2026-06-05T06:33:00Z

[INFO] PR Label Summary by Default
[FAILED] PR #49654 not merged

Title: enhance: [2.6] adds dimensions support for TEI text embedding.
Status: OPEN
Link: enhance: [2.6] adds dimensions support for TEI text embedding. #49654

Use /refresh-label to update related check and label manually

sre-ci-robot requested review from xiaofan-luan and yanliang567 May 9, 2026 08:49

sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 9, 2026

mergify Bot added the dco-passed DCO check passed. label May 9, 2026

mergify Bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels May 9, 2026

sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels May 9, 2026

mergify Bot removed the do-not-merge/missing-related-pr label May 9, 2026

sre-ci-robot added low-code-coverage add test-label from zhikun, diff coverage > 80% and removed low-code-coverage add test-label from zhikun, diff coverage > 80% labels May 9, 2026

sre-ci-robot added this to the 2.6.16 milestone May 9, 2026

sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label May 9, 2026

yanliang567 modified the milestones: 2.6.16, 2.6.17 May 15, 2026

mergify Bot added the ci-passed label May 20, 2026

yanliang567 modified the milestones: 2.6.17, 2.6.18 May 22, 2026

czs007 modified the milestones: 2.6.18, 2.6.19 Jun 1, 2026

Conversation

melodyshu commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

mergify Bot commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

melodyshu commented May 9, 2026

Uh oh!

codecov Bot commented May 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melodyshu commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

melodyshu commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

melodyshu commented May 9, 2026

Uh oh!

sre-ci-robot commented May 9, 2026

Uh oh!

sre-ci-robot commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

melodyshu commented May 9, 2026 •

edited

Loading

codecov Bot commented May 9, 2026 •

edited

Loading