Skip to content

enhance: [2.6] make function runner analyzer concurrency configurable (#50112)#50115

Open
aoiasd wants to merge 1 commit into
milvus-io:2.6from
aoiasd:fix/function-runner-tokenizer-concurrency_2.6
Open

enhance: [2.6] make function runner analyzer concurrency configurable (#50112)#50115
aoiasd wants to merge 1 commit into
milvus-io:2.6from
aoiasd:fix/function-runner-tokenizer-concurrency_2.6

Conversation

@aoiasd

@aoiasd aoiasd commented May 27, 2026

Copy link
Copy Markdown
Contributor

relate: #50113
pr: #50112

Summary

Make function runner text tokenization concurrency configurable and let analyzer pool concurrency resize when the analyzer concurrency config changes.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 27, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 27, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@mergify

mergify Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

@aoiasd Please associate the related issue to the body of your Pull Request. (eg. "issue: #")

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label May 27, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.35052% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.64%. Comparing base (cb08db0) to head (82897c8).
⚠️ Report is 940 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/util/function/bm25_function.go 65.45% 14 Missing and 5 partials ⚠️
...rnal/util/function/multi_analyzer_bm25_function.go 88.88% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (78.35%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #50115      +/-   ##
==========================================
+ Coverage   76.99%   77.64%   +0.65%     
==========================================
  Files        1700     1999     +299     
  Lines      262533   328465   +65932     
==========================================
+ Hits       202142   255047   +52905     
- Misses      53550    65566   +12016     
- Partials     6841     7852    +1011     
Components Coverage Δ
Client 79.48% <74.73%> (+1.34%) ⬆️
Core 84.42% <ø> (+2.21%) ⬆️
Go 75.75% <56.51%> (+0.36%) ⬆️
Files with missing lines Coverage Δ
pkg/util/paramtable/function_param.go 89.07% <100.00%> (+53.25%) ⬆️
...rnal/util/function/multi_analyzer_bm25_function.go 67.78% <88.88%> (+1.80%) ⬆️
internal/util/function/bm25_function.go 71.91% <65.45%> (-4.13%) ⬇️

... and 1411 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot removed the low-code-coverage add test-label from zhikun, diff coverage > 80% label May 27, 2026
@aoiasd aoiasd force-pushed the fix/function-runner-tokenizer-concurrency_2.6 branch from c99302e to 82897c8 Compare May 28, 2026 11:56
@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label May 28, 2026
@mergify mergify Bot added the ci-passed label May 28, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved do-not-merge/need-milestone generate by v2-label-manager labels Jun 1, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #50112 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@aoiasd

aoiasd commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/set-milestone 2.6.19

@aoiasd

aoiasd commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

/refresh-label

@sre-ci-robot sre-ci-robot added this to the 2.6.19 milestone Jun 8, 2026
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Jun 8, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] Set milestone to: 2.6.19

@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #50112 merged to master

Use /refresh-label to update related check and label manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement low-code-coverage add test-label from zhikun, diff coverage > 80% size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants