Skip to content

enhance: [2.6] Make max array capacity configurable#50265

Open
zhengbuqian wants to merge 2 commits into
milvus-io:2.6from
zhengbuqian:bq/array-capacity-lift-2.6
Open

enhance: [2.6] Make max array capacity configurable#50265
zhengbuqian wants to merge 2 commits into
milvus-io:2.6from
zhengbuqian:bq/array-capacity-lift-2.6

Conversation

@zhengbuqian

Copy link
Copy Markdown
Collaborator

issue: #50263
pr: #50264

This PR makes max array capacity configurable, preparing for row level multi-user sharing

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@zhengbuqian zhengbuqian added this to the 2.6.19 milestone Jun 3, 2026
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 3, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 3, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.73%. Comparing base (cb08db0) to head (d9194cb).
⚠️ Report is 939 commits behind head on 2.6.

Files with missing lines Patch % Lines
pkg/util/paramtable/component_param.go 81.81% 1 Missing and 1 partial ⚠️
internal/proxy/msg_pack.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #50265      +/-   ##
==========================================
+ Coverage   76.99%   77.73%   +0.73%     
==========================================
  Files        1700     1999     +299     
  Lines      262533   328905   +66372     
==========================================
+ Hits       202142   255675   +53533     
- Misses      53550    65389   +11839     
- Partials     6841     7841    +1000     
Components Coverage Δ
Client 79.48% <74.73%> (+1.34%) ⬆️
Core 84.58% <45.83%> (+2.37%) ⬆️
Go 75.80% <55.09%> (+0.41%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task.go 77.95% <100.00%> (-0.75%) ⬇️
internal/proxy/util.go 80.09% <100.00%> (-2.40%) ⬇️
internal/proxy/msg_pack.go 85.96% <0.00%> (+1.34%) ⬆️
pkg/util/paramtable/component_param.go 97.34% <81.81%> (-0.41%) ⬇️

... and 1409 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 3, 2026
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@zhengbuqian

Copy link
Copy Markdown
Collaborator Author

/ci-rerun-ut-cpp

1 similar comment
@zhengbuqian

Copy link
Copy Markdown
Collaborator Author

/ci-rerun-ut-cpp

@mergify mergify Bot added the ci-passed label Jun 4, 2026
@sre-ci-robot sre-ci-robot added the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Jun 5, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #50264 not merged

Use /refresh-label to update related check and label manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/enhancement Issues or changes related to enhancement low-code-coverage add test-label from zhikun, diff coverage > 80% size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants