fix: [2.6] align expression cursor with scalar index raw data by sparknack · Pull Request #50266 · milvus-io/milvus

sparknack · 2026-06-03T08:18:22Z

sre-ci-robot · 2026-06-03T08:18:31Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sparknack
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

internal/core/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot · 2026-06-03T08:22:07Z

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
/ci-rerun-build // for ci-v2/build
/ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
/ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
/ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
/ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
/ci-rerun-e2e-default // for ci-v2/e2e-default
/ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
/ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
/ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

codecov · 2026-06-03T09:27:40Z

Codecov Report

❌ Patch coverage is 85.32110% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.75%. Comparing base (cb08db0) to head (55ccbc9).
⚠️ Report is 943 commits behind head on 2.6.

Files with missing lines	Patch %	Lines
.../src/segcore/ChunkedSegmentSealedStorageV2Test.cpp	87.23%	30 Missing ⚠️
internal/core/src/exec/expression/ColumnExpr.h	50.00%	9 Missing ⚠️
internal/core/src/segcore/SegmentChunkReader.cpp	82.00%	9 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              2.6   #50266      +/-   ##
==========================================
+ Coverage   76.99%   77.75%   +0.75%     
==========================================
  Files        1700     1999     +299     
  Lines      262533   329375   +66842     
==========================================
+ Hits       202142   256108   +53966     
- Misses      53550    65428   +11878     
- Partials     6841     7839     +998

Components	Coverage Δ
Client	`79.48% <74.73%> (+1.34%)`	⬆️
Core	`84.64% <45.83%> (+2.42%)`	⬆️
Go	`75.79% <55.09%> (+0.40%)`	⬆️

Files with missing lines	Coverage Δ
internal/core/src/exec/expression/ColumnExpr.cpp	`74.50% <100.00%> (+6.24%)`	⬆️
internal/core/src/exec/expression/CompareExpr.cpp	`94.97% <100.00%> (-0.03%)`	⬇️
internal/core/src/exec/expression/CompareExpr.h	`79.62% <100.00%> (+6.98%)`	⬆️
internal/core/src/mmap/ChunkedColumnGroup.h	`52.61% <100.00%> (+8.34%)`	⬆️
internal/core/src/segcore/SegmentChunkReader.h	`48.78% <ø> (+35.87%)`	⬆️
internal/core/src/exec/expression/ColumnExpr.h	`62.06% <50.00%> (-0.98%)`	⬇️
internal/core/src/segcore/SegmentChunkReader.cpp	`69.26% <82.00%> (+5.08%)`	⬆️
.../src/segcore/ChunkedSegmentSealedStorageV2Test.cpp	`93.37% <87.23%> (-6.14%)`	⬇️

... and 1406 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sparknack · 2026-06-03T15:16:25Z

/ci-rerun-build

sparknack · 2026-06-03T17:21:03Z

/ci-rerun-e2e-default

sparknack · 2026-06-03T17:21:03Z

/ci-rerun-ut

sparknack · 2026-06-03T17:21:04Z

/ci-rerun-gosdk

sparknack · 2026-06-03T20:29:43Z

/ci-rerun-ut

sparknack · 2026-06-03T21:33:13Z

/ci-rerun-gosdk

sre-ci-robot · 2026-06-05T06:32:22Z

[INFO] PR Label Summary by Default
[FAILED] PR #50233 not merged

Title: fix: align expression cursor with scalar index raw data
Status: OPEN
Link: fix: align expression cursor with scalar index raw data #50233

[WARNING] Milestone not set

PR: fix: [2.6] align expression cursor with scalar index raw data #50266
Title: fix: [2.6] align expression cursor with scalar index raw data
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sre-ci-robot · 2026-06-08T06:48:29Z

[INFO] PR Label Summary by Default
[FAILED] PR #50233 not merged

Title: fix: align expression cursor with scalar index raw data
Status: OPEN
Link: fix: align expression cursor with scalar index raw data #50233

[WARNING] Milestone not set

PR: fix: [2.6] align expression cursor with scalar index raw data #50266
Title: fix: [2.6] align expression cursor with scalar index raw data
Please set a milestone for better release tracking

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

sparknack · 2026-06-08T06:53:07Z

/set-milestone 2.6.19

sre-ci-robot · 2026-06-08T06:53:58Z

[INFO] Set milestone to: 2.6.19

sre-ci-robot · 2026-06-08T06:56:32Z

[INFO] PR Label Summary by Default
[FAILED] PR #50233 not merged

Title: fix: align expression cursor with scalar index raw data
Status: OPEN
Link: fix: align expression cursor with scalar index raw data #50233

Use /refresh-label to update related check and label manually

sparknack · 2026-06-09T08:33:26Z

/set-milestone 2.6.19

sre-ci-robot · 2026-06-09T08:34:05Z

[INFO] Set milestone to: 2.6.19

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

sre-ci-robot · 2026-06-09T08:54:35Z

[INFO] PR Label Summary by Default
[FAILED] PR #50233 not merged

Title: fix: align expression cursor with scalar index raw data
Status: OPEN
Link: fix: align expression cursor with scalar index raw data #50233

Use /refresh-label to update related check and label manually

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

sre-ci-robot · 2026-06-09T12:00:09Z

[INFO] PR Label Summary by Default
[FAILED] PR #50233 not merged

Title: fix: align expression cursor with scalar index raw data
Status: OPEN
Link: fix: align expression cursor with scalar index raw data #50233

Use /refresh-label to update related check and label manually

sparknack · 2026-06-10T03:28:23Z

/ci-rerun-e2e-default

sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 3, 2026

sre-ci-robot requested review from czs007 and godchen0212 June 3, 2026 08:18

mergify Bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 3, 2026

sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 3, 2026

mergify Bot added the ci-passed label Jun 3, 2026

sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Jun 5, 2026

sparknack force-pushed the fix/index-cursor-origin-26 branch from 568bdb8 to bb7639b Compare June 8, 2026 06:46

sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jun 8, 2026

mergify Bot removed the ci-passed label Jun 8, 2026

sre-ci-robot added this to the 2.6.19 milestone Jun 8, 2026

sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Jun 8, 2026

sparknack force-pushed the fix/index-cursor-origin-26 branch from bb7639b to 9ce83bb Compare June 8, 2026 06:55

sparknack added 5 commits June 9, 2026 08:34

fix: align expression cursor with scalar index raw data

c68f716

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

test: cover scalar index raw data cursor alignment

1ae3ff8

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

test: adapt storage v2 cursor test for 2.6

1544625

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

fix: guard chunk data raw lookup access

5bc21c7

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

fix: avoid macos openmp structured binding capture

58ccf5b

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

sparknack force-pushed the fix/index-cursor-origin-26 branch from 9ce83bb to 58ccf5b Compare June 9, 2026 08:53

fix: adapt storage v2 cursor tests for 2.6

55ccbc9

Signed-off-by: Shawn Wang <shawn.wang@zilliz.com>

mergify Bot added the ci-passed label Jun 10, 2026

Conversation

sparknack commented Jun 3, 2026

Uh oh!

sre-ci-robot commented Jun 3, 2026

Uh oh!

sre-ci-robot commented Jun 3, 2026

Uh oh!

codecov Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sparknack commented Jun 3, 2026

Uh oh!

sre-ci-robot commented Jun 5, 2026

Uh oh!

sre-ci-robot commented Jun 8, 2026

Uh oh!

sparknack commented Jun 8, 2026

Uh oh!

sre-ci-robot commented Jun 8, 2026

Uh oh!

sre-ci-robot commented Jun 8, 2026

Uh oh!

sparknack commented Jun 9, 2026

Uh oh!

sre-ci-robot commented Jun 9, 2026

Uh oh!

sre-ci-robot commented Jun 9, 2026

Uh oh!

sre-ci-robot commented Jun 9, 2026

Uh oh!

sparknack commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jun 3, 2026 •

edited

Loading