fix: [2.6] Pass OpContext to PinCells calls (#50231)#50303
Open
congqixia wants to merge 2 commits into
Open
Conversation
Related to milvus-io#50230 Pass op ctx to `PinCells` calls during search & query cgo calls so that AsyncCGO cancellation could be detected by cachying layer avoiding waste waiting time for resource requesting. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
Bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.6 #50303 +/- ##
==========================================
+ Coverage 76.99% 77.74% +0.74%
==========================================
Files 1700 1999 +299
Lines 262533 328895 +66362
==========================================
+ Hits 202142 255702 +53560
- Misses 53550 65355 +11805
- Partials 6841 7838 +997
🚀 New features to boost your workflow:
|
sre-ci-robot
added
the
low-code-coverage
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
added
size/L
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from master
pr: #50231
Related to #50230
Pass op ctx to
PinCellscalls during search & query cgo calls so that AsyncCGO cancellation could be detected by cachying layer avoiding waste waiting time for resource requesting.