fix: validate dump messages start message id#50349
Conversation
Signed-off-by: proobker <rabimenuka1@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: proobker The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 14.5min | - |
| ✅ Code-Check | SUCCESS | 8.4min | - |
| ✅ UT-GO | SUCCESS | 23.5min | 1012 passed |
| ✅ UT-Integration | SUCCESS | 25.7min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 54.0min | 7851 passed |
Total: 82min | Pipeline | Artifacts
Overall Coverage: 71.2%
Diff Coverage: Go 100.0% (4 hit, 0 miss, 4 measurable lines, 0 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 100.0% (4/4 measurable lines, 0 unmeasured)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #50349 +/- ##
==========================================
- Coverage 79.01% 78.99% -0.03%
==========================================
Files 2236 2236
Lines 396046 396046
==========================================
- Hits 312925 312841 -84
- Misses 73607 73668 +61
- Partials 9514 9537 +23
🚀 New features to boost your workflow:
|
Fixes #50341
DumpMessages previously used MustUnmarshalMessageID on client-provided start_message_id bytes. A malformed message ID could panic and crash the process.
This change uses the non-panicking UnmarshalMessageID path and returns an invalid parameter error instead.
Added regression coverage for malformed Pulsar start_message_id bytes.