Skip to content

enhance: [cp2.6]add DumpMessages to the Go SDK client (#50343)#50370

Open
bigsheeper wants to merge 1 commit into
milvus-io:2.6from
bigsheeper:cp-2.6-50343
Open

enhance: [cp2.6]add DumpMessages to the Go SDK client (#50343)#50370
bigsheeper wants to merge 1 commit into
milvus-io:2.6from
bigsheeper:cp-2.6-50343

Conversation

@bigsheeper

Copy link
Copy Markdown
Contributor

Cherry-pick from master

pr: #50343
issue: #47598

Summary

Cherry-picked from master PR #50343 (merged). Adds Client.DumpMessages to the Go SDK (client/milvusclient), mirroring CreateReplicateStream, plus ExampleClient_DumpMessages.

Verified the 2.6-pinned go-api/v2 already exposes the DumpMessages stub / DumpMessagesRequest / GetSalvageCheckpoint, so the code compiles unchanged on 2.6.

Verification

  • File count matches original PR (2 files, 82 insertions)
  • Per-file diffs verified identical to master PR enhance: add DumpMessages to the Go SDK client #50343
  • No conflict markers
  • go build / go vet ./milvusclient/ pass on 2.6 (go-api/v2)
  • go test -run TestReplicate passes
  • make static-check (skipped by cherry-pick workflow)

Cherry-pick from master PR milvus-io#50343

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 8, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 8, 2026
@sre-ci-robot sre-ci-robot added the do-not-merge/need-milestone generate by v2-label-manager label Jun 8, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[SUCCESS] PR #50343 merged to master

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.68%. Comparing base (cb08db0) to head (0a961c2).
⚠️ Report is 940 commits behind head on 2.6.

Files with missing lines Patch % Lines
client/milvusclient/replicate.go 0.00% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #50370      +/-   ##
==========================================
+ Coverage   76.99%   77.68%   +0.68%     
==========================================
  Files        1700     1999     +299     
  Lines      262533   328207   +65674     
==========================================
+ Hits       202142   254952   +52810     
- Misses      53550    65443   +11893     
- Partials     6841     7812     +971     
Components Coverage Δ
Client 79.35% <74.09%> (+1.21%) ⬆️
Core 84.42% <ø> (+2.21%) ⬆️
Go 75.80% <56.32%> (+0.41%) ⬆️
Files with missing lines Coverage Δ
client/milvusclient/replicate.go 20.00% <0.00%> (+20.00%) ⬆️

... and 1411 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigsheeper bigsheeper modified the milestones: 2.6.18, 2.6.19 Jun 8, 2026
@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 8, 2026
@mergify mergify Bot added the ci-passed label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. do-not-merge/need-milestone generate by v2-label-manager kind/enhancement Issues or changes related to enhancement low-code-coverage add test-label from zhikun, diff coverage > 80% size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants