fix: avoid redundant schema reopen locking in segcore#50378
Open
congqixia wants to merge 1 commit into
Open
Conversation
Related to milvus-io#50103 Cache the sealed segment schema version in an atomic and use it as a fast path before taking mutex_ during reopen. Double-check the version under the write lock before publishing schema changes so stale or duplicate reopen requests return early without contending on schema updates. Note: this patch is only a cheap fix for non-schema lock contention. the root shall be fixed after lock usage improvement Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
Bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 10.6min | - |
| ✅ Code-Check | SUCCESS | 4.8min | - |
| ✅ UT-GO | SUCCESS | 14.4min | 1012 passed |
| ✅ UT-Integration | SUCCESS | 24.0min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 48.6min | 7835 passed |
Total: 64min | Pipeline | Artifacts
Overall Coverage: 71.3%
Diff Coverage: CPP 83.3% (25 hit, 5 miss, 30 measurable lines, 18 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 83.3% (25/30 measurable lines, 18 unmeasured)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50378 +/- ##
==========================================
- Coverage 79.01% 78.96% -0.06%
==========================================
Files 2239 2239
Lines 396634 396645 +11
==========================================
- Hits 313391 313197 -194
- Misses 73703 73865 +162
- Partials 9540 9583 +43
🚀 New features to boost your workflow:
|
sre-ci-robot
added
low-code-coverage
Contributor
Author
|
/ci-rerun-e2e-default |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #50103
Cache the sealed segment schema version in an atomic and use it as a fast path before taking mutex_ during reopen. Double-check the version under the write lock before publishing schema changes so stale or duplicate reopen requests return early without contending on schema updates.
Note: this patch is only a cheap fix for non-schema lock contention. the root shall be fixed after lock usage improvement