Skip to content

fix: [cp2.6] support CPU adaptation for GPU CAGRA loading (#50096)#50385

Open
marcelo-cjl wants to merge 1 commit into
milvus-io:2.6from
marcelo-cjl:cherrypick-50096-2.6
Open

fix: [cp2.6] support CPU adaptation for GPU CAGRA loading (#50096)#50385
marcelo-cjl wants to merge 1 commit into
milvus-io:2.6from
marcelo-cjl:cherrypick-50096-2.6

Conversation

@marcelo-cjl

@marcelo-cjl marcelo-cjl commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Cherry-pick from master

pr: #50096
issue: #49836

Summary

  • Treat GPU CAGRA indexes with adapt_for_cpu enabled as CPU-adapted in QueryNode resource checks.
  • Apply the same GPU requirement check when estimating segment load resources and collection GPU index flags.
  • Keep the Milvus-side OpenBLAS Conan option needed by the current Knowhere dependency set on 2.6.

Test plan

  • git diff --check upstream/2.6..HEAD
  • GO_DIFF_FILES="internal/datanode/index_services_test.go internal/querynodev2/segments/collection.go internal/querynodev2/segments/collection_test.go internal/querynodev2/segments/segment_loader.go internal/querynodev2/segments/segment_loader_test.go" make fmt
  • go test -count=1 -tags test ./internal/querynodev2/segments -run 'TestGpuIndexRequiresGpu|TestCollectionManagerSuite/TestGpuIndexFlagWithCagraAdaptForCPU' blocked locally because this clean 2.6 workspace has not built internal/core/output/lib/libmilvus_core.so.

Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
(cherry picked from commit 22f5f9b)
Signed-off-by: marcelo-cjl <marcelo.chen@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcelo-cjl
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 8, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 8, 2026
@marcelo-cjl marcelo-cjl added this to the 2.6.19 milestone Jun 8, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Jun 8, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #50096 not merged

Use /refresh-label to update related check and label manually

@marcelo-cjl marcelo-cjl changed the title fix: [2.6] support CPU adaptation for GPU CAGRA loading (#50096) fix: [cp2.6] support CPU adaptation for GPU CAGRA loading (#50096) Jun 8, 2026
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.57%. Comparing base (cb08db0) to head (62ce95a).
⚠️ Report is 940 commits behind head on 2.6.

❗ There is a different number of reports uploaded between BASE (cb08db0) and HEAD (62ce95a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (cb08db0) HEAD (62ce95a)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.6   #50385       +/-   ##
===========================================
- Coverage   76.99%   42.57%   -34.42%     
===========================================
  Files        1700       12     -1688     
  Lines      262533     1893   -260640     
===========================================
- Hits       202142      806   -201336     
+ Misses      53550     1035    -52515     
+ Partials     6841       52     -6789     
Components Coverage Δ
Client ∅ <ø> (∅)
Core ∅ <ø> (∅)
Go ∅ <ø> (∅)
see 1697 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/bug Issues or changes related a bug low-code-coverage add test-label from zhikun, diff coverage > 80% size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants