Skip to content

feat: define external snapshot API contracts (part1)#50393

Open
weiliu1031 wants to merge 3 commits into
milvus-io:masterfrom
weiliu1031:restore-snapshot-cross-cluster-part1
Open

feat: define external snapshot API contracts (part1)#50393
weiliu1031 wants to merge 3 commits into
milvus-io:masterfrom
weiliu1031:restore-snapshot-cross-cluster-part1

test: regenerate external snapshot mixcoord mocks

65b21a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 30, 2026 in 1s

79.35% (target 77.00%)

View this Pull Request on Codecov

79.35% (target 77.00%)

Details

Codecov Report

❌ Patch coverage is 80.94059% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.35%. Comparing base (b4dd2b2) to head (65b21a6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/snapshot_impl.go 64.76% 29 Missing and 8 partials ⚠️
internal/distributed/mixcoord/client/client.go 0.00% 9 Missing ⚠️
...nternal/distributed/proxy/httpserver/handler_v2.go 92.80% 6 Missing and 3 partials ⚠️
client/milvusclient/snapshot_options.go 85.71% 8 Missing ⚠️
internal/distributed/proxy/service.go 0.00% 4 Missing ⚠️
internal/datacoord/services.go 78.57% 2 Missing and 1 partial ⚠️
internal/proxy/rate_limit_interceptor.go 50.00% 2 Missing and 1 partial ⚠️
internal/coordinator/mix_coord.go 0.00% 2 Missing ⚠️
internal/distributed/mixcoord/service.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #50393      +/-   ##
==========================================
+ Coverage   79.34%   79.35%   +0.01%     
==========================================
  Files        2280     2280              
  Lines      415331   415732     +401     
==========================================
+ Hits       329554   329922     +368     
- Misses      75630    75662      +32     
- Partials    10147    10148       +1     
Components Coverage Δ
Client 80.76% <92.00%> (+0.11%) ⬆️
Core 86.50% <ø> (ø)
Go 76.99% <77.30%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
client/milvusclient/snapshot.go 65.86% <100.00%> (+12.20%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 89.23% <100.00%> (+0.05%) ⬆️
internal/proxy/database_interceptor.go 86.55% <100.00%> (+0.37%) ⬆️
internal/proxy/trace_log_interceptor.go 100.00% <100.00%> (ø)
internal/proxy/util.go 79.11% <100.00%> (+0.10%) ⬆️
pkg/util/constant.go 31.25% <ø> (ø)
internal/coordinator/mix_coord.go 60.30% <0.00%> (-0.15%) ⬇️
internal/distributed/mixcoord/service.go 71.72% <0.00%> (-0.27%) ⬇️
internal/datacoord/services.go 82.03% <78.57%> (-0.03%) ⬇️
internal/proxy/rate_limit_interceptor.go 78.12% <50.00%> (-1.39%) ⬇️
... and 5 more

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.