Skip to content

fix: struct hybrid collapse validation#50399

Open
zhengbuqian wants to merge 2 commits into
milvus-io:masterfrom
zhengbuqian:fix-struct-hybrid-master
Open

fix: struct hybrid collapse validation#50399
zhengbuqian wants to merge 2 commits into
milvus-io:masterfrom
zhengbuqian:fix-struct-hybrid-master

Conversation

@zhengbuqian

Copy link
Copy Markdown
Collaborator

issue: #42148

fixing issues during review of #50369

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 9, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 9, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results a26d2dd

Stage Result Duration Tests
✅ Build SUCCESS 10.0min -
✅ Code-Check SUCCESS 5.2min -
✅ UT-GO SUCCESS 17.5min 1020 passed
✅ UT-Integration SUCCESS 23.6min 46 passed
✅ UT-CPP-Cov SUCCESS 36.5min 7836 passed

Total: 65min | Pipeline | Artifacts

Overall Coverage: 71.3%
Diff Coverage: Go 100.0% (5 hit, 0 miss, 5 measurable lines, 0 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 100.0% (5/5 measurable lines, 0 unmeasured)

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.95%. Comparing base (385caab) to head (3342086).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/struct_hybrid_search.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #50399      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.02%     
==========================================
  Files        2239     2239              
  Lines      396917   396929      +12     
==========================================
- Hits       313441   313393      -48     
- Misses      73900    73948      +48     
- Partials     9576     9588      +12     
Components Coverage Δ
Client 80.36% <ø> (-0.04%) ⬇️
Core 85.93% <ø> (ø)
Go 76.83% <86.95%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/search_pipeline.go 74.81% <100.00%> (ø)
internal/proxy/task_search.go 74.25% <100.00%> (ø)
internal/proxy/struct_hybrid_search.go 63.00% <76.92%> (+0.89%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added low-code-coverage add test-label from zhikun, diff coverage > 80% and removed low-code-coverage add test-label from zhikun, diff coverage > 80% labels Jun 9, 2026
@mergify mergify Bot added the ci-passed label Jun 9, 2026
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. ci-passed labels Jun 9, 2026
@zhengbuqian zhengbuqian added this to the 3.0 milestone Jun 9, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 3342086

Stage Result Duration Tests
✅ Build SUCCESS 9.9min -
✅ Code-Check SUCCESS 5.2min -
✅ UT-GO SUCCESS 17.8min 1020 passed
✅ UT-Integration SUCCESS 23.6min 46 passed
✅ UT-CPP-Cov SUCCESS 36.1min 7836 passed

Total: 69min | Pipeline | Artifacts

Overall Coverage: 57.8%
Diff Coverage: Go N/A (0 hit, 0 miss, 0 measurable lines, 28 unmeasured)
Diff Coverage HTML: view changed lines
Go Patch Warning: WARNING: Go patch coverage unavailable; changed Go lines did not match the coverage profile.
Total Patch Coverage: N/A (untrusted: changed source lines have no coverage data)

@sre-ci-robot sre-ci-robot added low-code-coverage add test-label from zhikun, diff coverage > 80% and removed low-code-coverage add test-label from zhikun, diff coverage > 80% labels Jun 9, 2026
if result == nil || result.GetResults() == nil || result.GetResults().GetElementIndices() == nil {
return result, nil
}
if isElementCollapseSumFamily(config.Strategy) && !largerScoreIsBetter {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why move this code snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants