fix: struct hybrid collapse validation#50399
Conversation
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 10.0min | - |
| ✅ Code-Check | SUCCESS | 5.2min | - |
| ✅ UT-GO | SUCCESS | 17.5min | 1020 passed |
| ✅ UT-Integration | SUCCESS | 23.6min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 36.5min | 7836 passed |
Total: 65min | Pipeline | Artifacts
Overall Coverage: 71.3%
Diff Coverage: Go 100.0% (5 hit, 0 miss, 5 measurable lines, 0 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 100.0% (5/5 measurable lines, 0 unmeasured)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #50399 +/- ##
==========================================
- Coverage 78.96% 78.95% -0.02%
==========================================
Files 2239 2239
Lines 396917 396929 +12
==========================================
- Hits 313441 313393 -48
- Misses 73900 73948 +48
- Partials 9576 9588 +12
🚀 New features to boost your workflow:
|
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 9.9min | - |
| ✅ Code-Check | SUCCESS | 5.2min | - |
| ✅ UT-GO | SUCCESS | 17.8min | 1020 passed |
| ✅ UT-Integration | SUCCESS | 23.6min | 46 passed |
| ✅ UT-CPP-Cov | SUCCESS | 36.1min | 7836 passed |
Total: 69min | Pipeline | Artifacts
Overall Coverage: 57.8%
Diff Coverage: Go N/A (0 hit, 0 miss, 0 measurable lines, 28 unmeasured)
Diff Coverage HTML: view changed lines
Go Patch Warning: WARNING: Go patch coverage unavailable; changed Go lines did not match the coverage profile.
Total Patch Coverage: N/A (untrusted: changed source lines have no coverage data)
| if result == nil || result.GetResults() == nil || result.GetResults().GetElementIndices() == nil { | ||
| return result, nil | ||
| } | ||
| if isElementCollapseSumFamily(config.Strategy) && !largerScoreIsBetter { |
There was a problem hiding this comment.
Why move this code snippet.
issue: #42148
fixing issues during review of #50369