Skip to content

test: align python client expectations with current API responses#50414

Merged
sre-ci-robot merged 2 commits into
milvus-io:masterfrom
NicoYuan1986:test-align-python-client-expectations-20260609
Jun 10, 2026
Merged

test: align python client expectations with current API responses#50414
sre-ci-robot merged 2 commits into
milvus-io:masterfrom
NicoYuan1986:test-align-python-client-expectations-20260609

Conversation

@NicoYuan1986

Copy link
Copy Markdown
Contributor

Summary

  • update test_milvus_client_collection_describe to expect properties.max_field_id in describe_collection
  • align search_aggregation JSON/dynamic field rejection cases with the current server error messages
  • keep the affected Python client regressions covered without asserting outdated responses

Test plan

  • python3 -m py_compile tests/python_client/milvus_client/test_milvus_client_collection.py tests/python_client/milvus_client/test_milvus_client_search_aggregation.py
  • full pytest execution was not run locally in this submission

🤖 Generated with Claude Code

- include max_field_id in describe_collection expectations
- align search_aggregation JSON/dynamic field errors with current server responses

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: nico <cheng.yuan@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 9, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/test labels Jun 9, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

- format the JSON metric rejection expectation to satisfy changed-files Ruff checks

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: nico <cheng.yuan@zilliz.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jun 9, 2026
@mergify mergify Bot added the ci-passed label Jun 9, 2026
@yanliang567

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicoYuan1986, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fe827c9 into milvus-io:master Jun 10, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants