Skip to content

fix: preserve element indices schema for empty element-level search results#50417

Open
SpadeA-Tang wants to merge 1 commit into
milvus-io:masterfrom
SpadeA-Tang:fix-50010
Open

fix: preserve element indices schema for empty element-level search results#50417
SpadeA-Tang wants to merge 1 commit into
milvus-io:masterfrom
SpadeA-Tang:fix-50010

Conversation

@SpadeA-Tang

Copy link
Copy Markdown
Contributor

issue: #50010

Signed-off-by: SpadeA <tangchenjie1210@gmail.com>
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 9, 2026
@mergify mergify Bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 9, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images; update .env after the new tag is ready)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@SpadeA-Tang

Copy link
Copy Markdown
Contributor Author

/set-milestone 3.0

@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 003d86e

Stage Result Duration Tests
✅ Build SUCCESS 11.7min -
✅ Code-Check SUCCESS 7.3min -
✅ UT-GO SUCCESS 22.5min 1020 passed
✅ UT-Integration SUCCESS 24.8min 46 passed
✅ UT-CPP-Cov SUCCESS 43.2min 7838 passed

Total: 71min | Pipeline | Artifacts

Overall Coverage: 71.3%
Diff Coverage: CPP 97.7% (42 hit, 1 miss, 43 measurable lines, 15 unmeasured)
Diff Coverage HTML: view changed lines
Total Patch Coverage: 97.7% (42/43 measurable lines, 15 unmeasured)

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.22%. Comparing base (fb65266) to head (003d86e).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #50417       +/-   ##
===========================================
+ Coverage   78.96%   85.22%    +6.25%     
===========================================
  Files        2239      671     -1568     
  Lines      396935   118435   -278500     
===========================================
- Hits       313430   100932   -212498     
+ Misses      73915    17451    -56464     
+ Partials     9590       52     -9538     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 85.95% <100.00%> (+<0.01%) ⬆️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
...ternal/core/src/exec/operator/VectorSearchNode.cpp 100.00% <100.00%> (ø)
internal/core/src/query/ExecPlanNodeVisitor.cpp 91.16% <100.00%> (+0.08%) ⬆️
internal/core/src/query/SearchOnGrowing.cpp 96.24% <100.00%> (+0.05%) ⬆️
internal/core/src/query/SearchOnSealed.cpp 97.14% <100.00%> (+0.08%) ⬆️
internal/core/src/query/Utils.h 80.35% <100.00%> (+0.35%) ⬆️
...ternal/core/src/segcore/search_result_export_c.cpp 70.72% <100.00%> (+0.76%) ⬆️
...l/core/src/segcore/search_result_export_c_test.cpp 98.59% <100.00%> (+0.03%) ⬆️

... and 1570 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify Bot added the ci-passed label Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants