-
Notifications
You must be signed in to change notification settings - Fork 392
Refactor: Introduce thread-safe GlobalSchemaCache for gRPC handlers #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jac0626 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @jac0626, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a fundamental refactoring of the schema caching mechanism within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: silas.jiang <[email protected]>
8ca419f to
b531314
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the schema caching mechanism by introducing a thread-safe, global LRU cache. This is a significant improvement that will reduce redundant describe_collection calls and enhance efficiency. The implementation of the GlobalSchemaCache singleton is solid, and the accompanying tests are comprehensive. I've provided a few suggestions to further refine the implementation for better performance and readability, such as using a more appropriate lock and simplifying some of the cache interaction patterns.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3188 +/- ##
=========================================
Coverage ? 46.95%
=========================================
Files ? 69
Lines ? 14860
Branches ? 0
=========================================
Hits ? 6977
Misses ? 7883
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: silas.jiang <[email protected]>
c8fde69 to
f65061f
Compare
XuanYang-cn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a popular library cachetools can help alot.
Signed-off-by: silas.jiang <[email protected]>
done |
pyproject.toml
Outdated
| "pandas>=1.2.4", | ||
| "numpy<1.25.0;python_version<='3.8'", | ||
| "cachetools>=5.0.0,<6.0.0;python_version<='3.8'", # Python 3.8 compatibility | ||
| "cachetools>=5.0.0;python_version>='3.9'", # Python 3.9+ can use latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second is redundent, see numpy for reference.
I think the first might be unnecessary too, because packages often maintain supported python ranges, and pip should be able to resolve it to the correct highest-version for python3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: silas.jiang <[email protected]>
see [Bug]: Implement Global Thread-Safe Schema Cache with Eviction Policy #3186