[1.x] Implement DIP for phone/landline validators.#124
Closed
mra9994 wants to merge 1 commit intomilwad-dev:1.xfrom
Closed
[1.x] Implement DIP for phone/landline validators.#124mra9994 wants to merge 1 commit intomilwad-dev:1.xfrom
mra9994 wants to merge 1 commit intomilwad-dev:1.xfrom
Conversation
Owner
|
I can't see the benefits of these changes! |
Owner
|
I think it’s fine as it is. |
milwad-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restructures the phone/landline validator to comply with the Dependency Inversion and Clean Architecture by separating abstraction from low-level implementation.
Changes
Reference
A similar approach is used by Mr Iman Ghafoori in package laravel-widgetize
NormalizerContract.phpis located at a higher level and separated from theNormalizersdirectory.