Skip to content

Refactor narrative_nodes.json: 57.7% line reduction via templates, merged actions, inline end nodes #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor narrative_nodes.json: 57.7% line reduction via templates, merged actions, inline end nodes #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba55013
Initial plan
Copilot Jul 12, 2026
6f8558b
Refactor narrative_nodes.json: 57.8% line reduction with templates, m…
Copilot Jul 12, 2026
a9db3fd
Fix code review: use action name as results_pool key, fix type annota…
Copilot Jul 12, 2026
e3e72c1
Address code review: simplify inline-end check to __end__ only, clari…
Copilot Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions game_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,12 +663,15 @@ def _handle_narrative_confirm(self):
# 查找下一节点
next_node_id = self.current_narrative_node.next_nodes.get(outcome_level)

if next_node_id:
# 检查是否是内联结束标记（"__end__" 字符串表示场景直接结束）
is_inline_end = next_node_id == "__end__"

if next_node_id and not is_inline_end:
print(f"[叙事] 跳转到下一节点: {next_node_id}")
# 切换到下一节点
self._start_narrative_scene(next_node_id)
else:
print(f"[叙事] 叙事结束（无下一节点）")
print(f"[叙事] 叙事结束（无下一节点或内联结束）")
# 退出叙事模式
self._exit_narrative_mode()

Expand Down
Loading