Skip to content
This repository was archived by the owner on Aug 21, 2026. It is now read-only.

update workflows - #306

Merged
mimmi20 merged 3 commits into
masterfrom
updates
Apr 9, 2026
Merged

update workflows#306
mimmi20 merged 3 commits into
masterfrom
updates

Conversation

@mimmi20

@mimmi20 mimmi20 commented Apr 9, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • New Features

    • Unterstützung für PHP 8.6 hinzugefügt.
  • Improvements

    • GitHub-Actions auf wiederverwendbare Workflows umgestellt; Berechtigungen und Job‑Statusauswertung verfeinert (skipped/cancelled als Fehler behandelt).
    • CI-Validierung, Analyse und Tests erweitert und angepasst.
    • PHPStan-Ausgabe im SARIF-Format ergänzt.
  • Chores

    • Dev‑Tools/Dev‑Abhängigkeiten aktualisiert und Composer‑Normalisierung konfiguriert.
    • Dependabot‑Ignorierregeln für Workflow‑Updates aktualisiert.

@mimmi20 mimmi20 self-assigned this Apr 9, 2026
@mimmi20 mimmi20 added the maintenance Maintenance label Apr 9, 2026
@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 07c238e1-844c-4284-9d94-8031c2f2736f

📥 Commits

Reviewing files that changed from the base of the PR and between de3ba50 and e093a42.

📒 Files selected for processing (1)
  • .github/workflows/continuous-integration.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/continuous-integration.yml

📝 Walkthrough

Walkthrough

Die PR migriert mehrere GitHub Actions zu wiederverwendbaren Workflows, erweitert Workflow-Berechtigungen und Status-Job-Logik, passt Dependabot-Ignore-Regeln an, erweitert Composer-Constraints und Dev-Tools sowie ergänzt einen PHPStan SARIF-Error-Formatter.

Changes

Cohort / File(s) Summary
Workflow reusable calls & status jobs
.github/workflows/cleanup-caches.yml, .github/workflows/dependency-review.yml, .github/workflows/labels.yml, .github/workflows/lock-closed-issues.yml, .github/workflows/reactions.yml, .github/workflows/release-drafter.yml
Inline-Job-Schritte wurden durch uses: mimmi20/ci/...@8.3 ersetzte wiederverwendbare Workflows; neue *-status Meta-Jobs hinzugefügt; Job-Namen und Berechtigungen teils angepasst.
Continuous-Integration (validate/install/analytics/tests)
.github/workflows/continuous-integration.yml
Aufteilung von Validierung in validate-all und validate-php; install, analytics und tests rufen PHP-spezifische reusable Workflows auf; zusätzliche Job-Permissions; neue Flags (use-code-scanning, use-phpstan, skip-infection: false) und Änderungen an ausgelassenen nativen Bibliotheken (librabbitmq, libgif).
Dependabot ignore & lint workflow inputs
.github/dependabot.yml, .github/workflows/lint-workflow-files.yml
Dependabot-Ignore-Einträge aktualisiert auf neue Workflow-Dateinamen und um zusätzliche repo-Workflows erweitert (lock-issues.yml, reaction-comments.yml, draft-release.yml); Lint-Workflow skip-Flags ergänzt (librabbitmq, libgif) und Status-Job-Bedingungen so angepasst, dass skipped/cancelled als Fehler gelten.
Cache cleanup refactor
.github/workflows/cleanup-caches.yml
Ersetzt inlined Cache-Cleanup-Logik durch Reusable-Workflow mimmi20/ci/.../cleanup-cache.yml@8.3; übergibt repository und berechnetes ref; fügt separaten cleanup-status Job hinzu.
Composer & PHPStan / Analyse-Skripte
composer.json, phpstan.neon, composer-dependency-analyser.php
Composer-Platform-Constraint um ~8.6.0 erweitert; Dev-Dependencies ergebnis/composer-normalize und jbelien/phpstan-sarif-formatter hinzugefügt; composer-normalize erlaubt/configuriert; phpstan.neon fügt SARIF-ErrorFormatter-Service hinzu; Dependency-Analyser ignoriert jbelien/phpstan-sarif-formatter.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐇 Ich schnüffel durch die Actions, flink und leis,

ersetz’ die Schritte — wiederverwendbar und heiß.
Composer wächst, SARIF blinkt im Schein,
die CI hüpft munter, flink wie ich — ganz fein.
Hopp, ein Update — fertig, fröhlich, klein.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive Der Titel ist zu vage und unspezifisch. Er verwendet den generischen Begriff "update workflows" ohne Details zu den tatsächlichen Änderungen zu geben. Verwenden Sie einen aussagekräftigeren Titel, der die Hauptänderungen zusammenfasst, z.B. "Refactor GitHub Actions workflows to use reusable workflows" oder "Update workflows with dependency and PHP 8.6 support".
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch updates

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA e093a42.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

License Issues

composer.json

PackageVersionLicenseIssue Type
php~> 8.3.0 || ~> 8.4.0 || ~> 8.5.0 || ~> 8.6.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
actions/mimmi20/ci/.github/workflows/sync-labels.yml 8.3 UnknownUnknown
actions/mimmi20/ci/.github/workflows/draft-release.yml 8.3 UnknownUnknown
composer/ergebnis/composer-normalize >= 2.50.0, < 3.0.0 UnknownUnknown
composer/jbelien/phpstan-sarif-formatter >= 1.2.0, < 2.0.0 UnknownUnknown
composer/php ~> 8.3.0 || ~> 8.4.0 || ~> 8.5.0 || ~> 8.6.0 UnknownUnknown

Scanned Files

  • .github/workflows/labels.yml
  • .github/workflows/release-drafter.yml
  • composer.json

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🧹 Nitpick comments (1)
.github/workflows/continuous-integration.yml (1)

23-26: Alle wiederverwendbaren Workflows auf feste Commit-SHAs pinnen statt auf Tags.

Alle @8.3-Referenzen sind bewegliche Tags. Damit ist die CI nicht vollständig reproduzierbar, und Änderungen im Fremd-Repository wirken sofort in diesen Pflichtpfad hinein. GitHub empfiehlt für uses: das Pinnen auf einen vollständigen Commit‑SHA – das ist die sicherste und unveränderliche Referenz.

Betroffen: Zeilen 26, 34, 52, 73, 90

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/continuous-integration.yml around lines 23 - 26, The
workflow references reusable workflows with movable tags (e.g., uses:
"mimmi20/ci/.github/workflows/validate-all.yml@8.3"); replace each tagged
reference with the corresponding full commit SHA for that repository (e.g.,
uses: "mimmi20/ci/.github/workflows/validate-all.yml@<full-commit-sha>") for all
occurrences (the shown uses: entries and the other uses: lines called out in the
comment) so the CI is pinned to immutable commits; locate and update the uses:
strings in the workflow file to the exact commit SHAs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/continuous-integration.yml:
- Around line 34-43: The CI workflow currently sets skip-validate-composer: true
which disables the validate-composer job in validate-php.yml and silences
composer validate; change the setting skip-validate-composer to false so the
validate-composer job runs (ensure the entry under the uses:
"mimmi20/ci/.github/workflows/validate-php.yml@8.3" block is updated), and
verify there are no other flags (e.g., skip-check-composer) unintentionally
preventing composer validate from executing alongside validate-all.yml@8.3.

In @.github/workflows/labels.yml:
- Around line 22-25: The reusable workflow is pinned to a movable tag
("mimmi20/ci/.github/workflows/sync-labels.yml@8.3"); replace the tag with the
exact full commit SHA to make the reference immutable. Update the uses entry
that currently reads uses: "mimmi20/ci/.github/workflows/sync-labels.yml@8.3" to
use the repository’s full commit SHA (found via the upstream repo’s commits page
or git ls-remote) so it becomes uses:
"mimmi20/ci/.github/workflows/sync-labels.yml@<full-commit-sha>" and commit that
change.

In @.github/workflows/release-drafter.yml:
- Line 34: Die externe reusable-Workflow-Referenz uses:
"mimmi20/ci/.github/workflows/draft-release.yml@8.3" verwendet ein bewegliches
Tag; ersetze das Tag (`@8.3`) durch die vollständige Commit-SHA des entsprechenden
commit im mimmi20/ci-Repo (z. B. uses:
"mimmi20/ci/.github/workflows/draft-release.yml@<full-commit-sha>") und
wiederhole diese Änderung konsistent für alle ähnlichen Einträge (z. B. in
continuous-integration.yml, reactions.yml, lint-workflow-files.yml), sodass jede
uses-Zeile auf ein unveränderliches Commit-SHA zeigt.

In `@composer.json`:
- Line 36: Add the new dev dependency jbelien/phpstan-sarif-formatter to the
analyzer ignore list by updating the composer-dependency-analyser.php
configuration: call the existing ignoreErrorsOnPackage helper for
'jbelien/phpstan-sarif-formatter' with ErrorType::UNUSED_DEPENDENCY (matching
how other tool deps like phpstan/extension-installer are added) so the
composer-dependency-analyser no longer flags it as unused. Ensure you use the
same method signature and placement as the other tool-dependencies in
composer-dependency-analyser.php.

---

Nitpick comments:
In @.github/workflows/continuous-integration.yml:
- Around line 23-26: The workflow references reusable workflows with movable
tags (e.g., uses: "mimmi20/ci/.github/workflows/validate-all.yml@8.3"); replace
each tagged reference with the corresponding full commit SHA for that repository
(e.g., uses: "mimmi20/ci/.github/workflows/validate-all.yml@<full-commit-sha>")
for all occurrences (the shown uses: entries and the other uses: lines called
out in the comment) so the CI is pinned to immutable commits; locate and update
the uses: strings in the workflow file to the exact commit SHAs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 623f6907-03aa-4ee1-bc49-3470e1aa9a45

📥 Commits

Reviewing files that changed from the base of the PR and between bbec5b6 and 0a88c2a.

📒 Files selected for processing (11)
  • .github/dependabot.yml
  • .github/workflows/cleanup-caches.yml
  • .github/workflows/continuous-integration.yml
  • .github/workflows/dependency-review.yml
  • .github/workflows/labels.yml
  • .github/workflows/lint-workflow-files.yml
  • .github/workflows/lock-closed-issues.yml
  • .github/workflows/reactions.yml
  • .github/workflows/release-drafter.yml
  • composer.json
  • phpstan.neon

Comment thread .github/workflows/continuous-integration.yml
Comment thread .github/workflows/labels.yml
Comment thread .github/workflows/release-drafter.yml
Comment thread composer.json
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bbec5b6) to head (e093a42).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #306   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        23        23           
===========================================
  Files              4         4           
  Lines             81        81           
===========================================
  Hits              81        81           
Flag Coverage Δ
php-8.3 100.00% <ø> (ø)
phpunit 100.00% <ø> (ø)
ubuntu-latest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@socket-security

socket-security Bot commented Apr 9, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedergebnis/​composer-normalize@​2.50.0.010010090100100
Addedjbelien/​phpstan-sarif-formatter@​1.2.0.010010090100100

View full report

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@composer.json`:
- Line 23: Die QA-Konfigurationen sind noch auf PHP 8.3 begrenzt: in
phpstan.neon die Einstellung phpVersion ist auf 80300 gesetzt und in rector.php
wird LevelSetList::UP_TO_PHP_83 verwendet; ändere phpstan.neon’s phpVersion auf
80600 (oder höher) und aktualisiere rector.php, sodass statt
LevelSetList::UP_TO_PHP_83 die passende Konstanten-Version
LevelSetList::UP_TO_PHP_86 (oder entsprechendes LevelSet für 8.6) verwendet
wird, damit PHPStan und Rector die neu hinzugefügte "~8.6.0" Constraint richtig
prüfen und modernisieren.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0aa2b966-4773-49b1-97ef-024fb9dcb42f

📥 Commits

Reviewing files that changed from the base of the PR and between 0a88c2a and de3ba50.

📒 Files selected for processing (2)
  • composer-dependency-analyser.php
  • composer.json
✅ Files skipped from review due to trivial changes (1)
  • composer-dependency-analyser.php

Comment thread composer.json
@mimmi20
mimmi20 merged commit 8bcfa9e into master Apr 9, 2026
74 checks passed
@mimmi20
mimmi20 deleted the updates branch April 9, 2026 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance Maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant