Skip to content

[MAINT] Run sklearn check_estimators on CFI and CFICV#599

Draft
Remi-Gau wants to merge 13 commits into
mind-inria:mainfrom
Remi-Gau:sklearn/CFI
Draft

[MAINT] Run sklearn check_estimators on CFI and CFICV#599
Remi-Gau wants to merge 13 commits into
mind-inria:mainfrom
Remi-Gau:sklearn/CFI

Conversation

@Remi-Gau

Copy link
Copy Markdown
Collaborator

@bthirion bthirion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

Comment thread test/conftest.py
Comment thread test/test_conditional_feature_importance.py Outdated
Comment thread test/conftest.py Outdated
Comment thread test/conftest.py Outdated
@Remi-Gau

Copy link
Copy Markdown
Collaborator Author

hmmm... I think we have a CI setup issue here: PRs opened from a fork cannot seem to be able to run PRs
@jpaillard can you confirm?

@jpaillard

Copy link
Copy Markdown
Collaborator

It looks like it. This was not a problem in the past, however: see #590

@Remi-Gau

Copy link
Copy Markdown
Collaborator Author

I think that's related to the latest version of the checkout action that was just updated

https://github.com/actions/checkout#whats-new

@bthirion bthirion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants