[DOC] Gallery rework: basic examples implementation#684
Conversation
…d documentation link to old example.
|
LMK when you want a review on it. |
|
This part is ready for review |
|
Can we see the rendered doc somewhere ? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 24 24
Lines 1756 1756
=======================================
Hits 1719 1719
Misses 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The doc can be seen here |
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
This looks good, but I have the impression that the numbering is not taken into account ?
|
Indeed the ordering is not here. I made the changes for the ordering on the branch that will merge all documentation changes. |
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
LGTM besides one detail.
|
|
||
| """ | ||
|
|
||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Can we avoid having all imports at the beginning, and rather have them when needed along the script ?
There was a problem hiding this comment.
yes, I think it makes more sense as it's closer to a notebook. I'll make the change over all the scripts
2 participants
I added basic examples folder, removed some previous examples that were related, and removed documentation link to old example.