Skip to content

[DOC] modify commit tag to build doc in draft PR#695

Open
jpaillard wants to merge 2 commits into
mainfrom
694-doc-commit-tag-to-build-the-doc-in-draft-prs
Open

[DOC] modify commit tag to build doc in draft PR#695
jpaillard wants to merge 2 commits into
mainfrom
694-doc-commit-tag-to-build-the-doc-in-draft-prs

Conversation

@jpaillard

@jpaillard jpaillard commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Unfortunately, we cannot see the effect of the modification in this PR. The workflow called is the one from main so it the effect will only be visible after merging.

pull_request_target:
# Using 'pull_request_target' instead of 'pull_request':
# 1. Uses configuration from the main branch
# 2. Provides access to secrets from the main repository
# 3. Prevents using potentially malicious workflow from forked PRs
branches: main

Use of AI tools:

  • LLM tools were used to generate at least part of the content of this pull request.

@jpaillard jpaillard linked an issue Jun 22, 2026 that may be closed by this pull request
1 task
@jpaillard jpaillard marked this pull request as ready for review June 22, 2026 11:06
@GrituX

GrituX commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

It works only if the commit contains the tag in lowercase ? I think it would be nice to have it for whichever case.

@bthirion bthirion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] commit tag to build the doc in draft PRs

3 participants