[DOC] Fixed shape inconsistencies in docstring for importance and selection arrays.#711
Open
GrituX wants to merge 1 commit into
Open
[DOC] Fixed shape inconsistencies in docstring for importance and selection arrays.#711GrituX wants to merge 1 commit into
GrituX wants to merge 1 commit into
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 24 24
Lines 1756 1756
=======================================
Hits 1719 1719
Misses 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bthirion
reviewed
Jul 10, 2026
bthirion
left a comment
bthirion
left a comment
Collaborator
There was a problem hiding this comment.
LGTM besides one small detail.
| P-values from one-sample t-test testing if importance scores are | ||
| significantly greater than 0. | ||
| The importance scores for each feature group. | ||
| A higher score indicates greater importance of that group. |
Collaborator
There was a problem hiding this comment.
Suggested change
| A higher score indicates greater importance of that group. | |
| A larger score indicates greater importance of that group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #708 for full detail of issues in the docstring.