Add Wasm support for AsyncMediaSource#53
Conversation
Code reviewFound 2 issues:
Lines 55 to 59 in ba2a417 Lines 150 to 156 in ba2a417 Lines 216 to 244 in ba2a417 Cargo.toml still on 3.4.1 (already released) — bump before publishing: Lines 1 to 7 in ba2a417 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
|
Yeah that's my bad, this was pretty quickly put together just to get it working on my side (which it does btw, ty for all your help in that regard). I'll clean all this up and request another review |
so that wasm32-unknown-unknown and similar targets can use the tokio feature for AsyncMediaSource
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage 89.84% 89.84%
=======================================
Files 38 38
Lines 8399 8399
=======================================
Hits 7546 7546
Misses 853 853
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should have everything you previously mentioned fixed. Let me know if you have any other concerns/suggestions. |
|
@mindeng Thanks for your quick responses! One thing that might be an issue is that if my understanding is correct this PR should be a SemVer breaking change, and people updating from 3.5 to 3.6 may have issues. I added the Not sure how you want to resolve this but going by strictly semver rules this should probably be a 4.0.0 release. |
Closes #52, option A as discussed in that issue.