Skip to content

Conversation

@mindstorm38
Copy link
Owner

@mindstorm38 mindstorm38 commented Feb 7, 2025

Changes

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

❌ Patch coverage is 16.36771% with 373 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.19%. Comparing base (cf57c77) to head (6d6f1b8).
⚠️ Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
portablemc/optifine.py 15.89% 344 Missing ⚠️
portablemc/cli/__init__.py 5.00% 19 Missing ⚠️
portablemc/auth.py 30.76% 9 Missing ⚠️
portablemc/standard.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   63.60%   58.19%   -5.42%     
==========================================
  Files          20       21       +1     
  Lines        3314     3832     +518     
==========================================
+ Hits         2108     2230     +122     
- Misses       1206     1602     +396     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mindstorm38 and others added 16 commits March 24, 2025 14:42
Add the possibility to download using query
Remove debug, improve install process, remove dependencies and add events.
many fixes, bring support for optifine search and installation in the CLI, use regex for version resolve
Add sha1sum checking to the optifine api
some formatting and improvements
Follow PEP standards and improve code readability
bugfix on x.x.0 optifine versions
Github desktop always wanted to push this file 😅, removing it.
Add some optifine use help
@mindstorm38
Copy link
Owner Author

Will be ported to the new Rust code at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants