Skip to content

Conversation

@i4ki
Copy link

@i4ki i4ki commented Mar 31, 2022

It's not ideal but already found a bug so adding here.

@i4ki i4ki requested review from katcipis and thiesen March 31, 2022 11:23
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to bump Go to 1.18

return
}

_ = markdown.Render(&w, def)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm maybe one property to check here is that if parsing worked, calling render should always write something on w if the return err is nil (not 100% sure this is always true, so maybe @thiesen can confirm). Like if the render suceeded, I think it always renders something, there is no scenario for empty rendering on terradoc I think 🤔 . But this can be done later anyway.

module github.com/mineiros-io/terradoc

go 1.17
go 1.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does terradoc now require at least go 1.18 ? 🤔

Copy link
Author

@i4ki i4ki Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added everything I had and committed.. this is not needed. With this change, I was testing if go1.17 still builds..

I'm going to mark this PR as draft.

@i4ki i4ki marked this pull request as draft March 31, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants