chore: add go fuzz support#39
Conversation
katcipis
left a comment
katcipis
left a comment
There was a problem hiding this comment.
Wondering if we need to bump Go to 1.18
| return | ||
| } | ||
|
|
||
| _ = markdown.Render(&w, def) |
There was a problem hiding this comment.
hmm maybe one property to check here is that if parsing worked, calling render should always write something on w if the return err is nil (not 100% sure this is always true, so maybe @thiesen can confirm). Like if the render suceeded, I think it always renders something, there is no scenario for empty rendering on terradoc I think 🤔 . But this can be done later anyway.
| module github.com/mineiros-io/terradoc | ||
|
|
||
| go 1.17 | ||
| go 1.18 |
There was a problem hiding this comment.
Does terradoc now require at least go 1.18 ? 🤔
There was a problem hiding this comment.
I just added everything I had and committed.. this is not needed. With this change, I was testing if go1.17 still builds..
I'm going to mark this PR as draft.
2 participants
It's not ideal but already found a bug so adding here.