Skip to content

upgrade provider versions#67

Open
kevcube wants to merge 1 commit into
mineiros-io:mainfrom
kevcube:upgrade_provider
Open

upgrade provider versions#67
kevcube wants to merge 1 commit into
mineiros-io:mainfrom
kevcube:upgrade_provider

Conversation

@kevcube
Copy link
Copy Markdown

@kevcube kevcube commented May 16, 2024

Upgrading to GH provider 6 to match a PR I am making in github-repository

@kevcube kevcube requested review from a team and mariux as code owners May 16, 2024 11:09
Comment thread versions.tf

terraform {
required_version = "~> 1.0, != 1.1.0, != 1.1.1"
required_version = "~> 1.7"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed the requirement to a minimum of Terraform 1.7 here?

Comment thread versions.tf
github = {
source = "integrations/github"
version = ">= 4.0, < 6.0"
version = "~> 6"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, why does this now require at least version 6 of the provider?

Arguably the correct fix here is to just remove the maximum version constraint as-per the Terraform documentation, i.e. just make it >= 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants