Skip to content

feat: add federated principal support#25

Closed
zonorti wants to merge 1 commit into
mineiros-io:mainfrom
klanggames:federated_principal
Closed

feat: add federated principal support#25
zonorti wants to merge 1 commit into
mineiros-io:mainfrom
klanggames:federated_principal

Conversation

@zonorti
Copy link
Copy Markdown

@zonorti zonorti commented May 3, 2024

To use workload federation this validation needs to be extended;

More information on federated principals

It seems like this validation is the only part that was blocking.

Similar to mineiros-io/terraform-google-storage-bucket-iam#21

Signed-off-by: Sergey Melnik <sergey@klang-games.com>
@zonorti zonorti requested review from a team and mariux as code owners May 3, 2024 10:03
Copy link
Copy Markdown
Member

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zied-elouaer
Copy link
Copy Markdown
Contributor

Done in #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants