feat: Add maximum player limit feature for lite #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ours1505
commented
Apr 19, 2025
ours1505
commented
- Added maxPlayers and maxPlayersMessage options in the configuration file to allow setting a maximum number of connected players and customizing the full message.
- Updated documentation to explain how to configure the maximum player limit.
- Implemented maximum player count check in connection handling logic, rejecting connection requests that exceed the limit and returning a custom message.
- Added maxPlayers and maxPlayersMessage options in the configuration file to allow setting a maximum number of connected players and customizing the full message. - Updated documentation to explain how to configure the maximum player limit. - Implemented maximum player count check in connection handling logic, rejecting connection requests that exceed the limit and returning a custom message.
robinbraemer
requested changes
Apr 23, 2025
| maxPlayers: 0 | ||
| # Custom message to show when the maximum player limit is reached. | ||
| # Default: §cThis Node is full.Please try another node. | ||
| maxPlayersMessage: "§cThis Node is full.Please try another node." |
There was a problem hiding this comment.
Should use our text config component like other settings do to support the different legacy and modern text types.
| Enabled: false, | ||
| Routes: []Route{}, | ||
| MaxPlayers: 0, // 0 means unlimited | ||
| MaxPlayersMessage: "§cThis Node is full.Please try another node.", |
There was a problem hiding this comment.
use text component directly. also don't call it Node, it's a proxy
Comment on lines
+29
to
+30
| MaxPlayers int `yaml:"maxPlayers,omitempty" json:"maxPlayers,omitempty"` // Maximum number of players to accept, 0 means unlimited | ||
| MaxPlayersMessage string `yaml:"maxPlayersMessage,omitempty" json:"maxPlayersMessage,omitempty"` // Message to show when reaching max players limit |
There was a problem hiding this comment.
We can put the player specific settings into a sub-struct Players struct { MaxPlayers, MaxMessage }
There was a problem hiding this comment.
We don't need this file. Just use atomic.Int64.
| ) | ||
|
|
||
| // ConnectionCounter tracks the number of active connections in LiteMode | ||
| var ConnectionCounter = &counter{} |
There was a problem hiding this comment.
We do not put global state like this. A process could run many Gate instances at once, they must have their own counter
| // Use the configured message | ||
| message := cfg.MaxPlayersMessage | ||
| if message == "" { | ||
| message = "§cThis Node is full.Please try another node." |
Comment on lines
+49
to
+70
| cfg := getConfig() | ||
| if cfg != nil && cfg.MaxPlayers > 0 { | ||
| currentCount := ConnectionCounter.Count() | ||
| if int(currentCount) >= cfg.MaxPlayers { | ||
| log.Info("connection rejected due to maximum player limit", | ||
| "current", currentCount, | ||
| "max", cfg.MaxPlayers) | ||
|
|
||
| // Use the configured message | ||
| message := cfg.MaxPlayersMessage | ||
| if message == "" { | ||
| message = "§cThis Node is full.Please try another node." | ||
| } | ||
|
|
||
| // Disconnect and display custom message | ||
| reason := &component.Text{ | ||
| Content: message, | ||
| S: component.Style{Color: color.Red}, | ||
| } | ||
| _ = netmc.CloseWith(client, packet.NewDisconnect(reason, client.Protocol(), client.State().State)) | ||
| return | ||
| } |
There was a problem hiding this comment.
Looks like a lot of code, let's put it into a helper function
Comment on lines
+96
to
+108
| // reference to the current lite mode config | ||
| var currentConfig *config.Config | ||
|
|
||
| // SetConfig sets the current lite mode config | ||
| func SetConfig(cfg *config.Config) { | ||
| currentConfig = cfg | ||
| } | ||
|
|
||
| // getConfig returns the current lite mode config | ||
| func getConfig() *config.Config { | ||
| return currentConfig | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a cheeky hack to pass state. It should be handled differently.
I don't want this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.