Skip to content

Translation - #21

Merged
SmallJoker merged 2 commits into
minetest-mods:masterfrom
Sheriff-Unit-3:translation
Aug 18, 2026
Merged

Translation#21
SmallJoker merged 2 commits into
minetest-mods:masterfrom
Sheriff-Unit-3:translation

Conversation

@Sheriff-Unit-3

Copy link
Copy Markdown
Member
  • Adds calls to core.get_translator for each node's description (I think I got them all...) and a .pot file.

Does not include any translations.

@Sheriff-Unit-3
Sheriff-Unit-3 marked this pull request as draft August 14, 2026 21:14
@Sheriff-Unit-3
Sheriff-Unit-3 force-pushed the translation branch 3 times, most recently from 976fce5 to d91a836 Compare August 14, 2026 21:28
@Sheriff-Unit-3
Sheriff-Unit-3 marked this pull request as ready for review August 14, 2026 21:29
@Sheriff-Unit-3

Copy link
Copy Markdown
Member Author

Rebased

@SmallJoker SmallJoker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the style change does not always improve readability.

Comment thread README.md Outdated
Comment thread angledglass.lua Outdated
Comment thread angledwalls.lua Outdated
Comment thread angledwalls.lua
Comment thread angledwalls.lua Outdated
@Sheriff-Unit-3

Copy link
Copy Markdown
Member Author

I'll see about removing the StyLua changes then.

@Sheriff-Unit-3
Sheriff-Unit-3 force-pushed the translation branch 2 times, most recently from b91ff1e to 6b89bc9 Compare August 15, 2026 20:26

@SmallJoker SmallJoker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough, I guess. Thank you for the changes.
Will merge in a few days unless there are objections.

@SmallJoker
SmallJoker merged commit 3ecaa30 into minetest-mods:master Aug 18, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants