Add eggfruit and ratatouille - #24
Conversation
SmallJoker
left a comment
SmallJoker
left a comment
There was a problem hiding this comment.
This looks quite good already. Did you also run optipng or pngcrush on your textures yet? On servers every byte matters :)
|
Hi @SmallJoker, thank you for your review. I tried to fix most issues and also did some refactoring in What do you think? |
|
Very nice, thank you for these changes. @sofar might want to have a quick look this this PR? He's more familiar with this code than me (even though it's quite simple). |
|
@sofar This PR is ready for merge. If there are no objections I will merge it soon. |
|
Uh Well in large the new addition seems fine, but, I don't understand why the tomato code needed to change. Sorry I didn't see this before, but, I think I'd like to make sure that we're not merging something that shouldn't be there. Also, translation changes should be separate commits. This is all squashed into 1 commit - fine for a new plant addition and a cooking recipe, but not for that many changes IMHO. |
|
|
||
| crops.tomato_die = function(pos) | ||
| minetest.set_node(pos, { name = "crops:tomato_plant_6", param2 = 1 }) | ||
| minetest.swap_node(pos, { name = "crops:tomato_plant_6", param2 = 1 }) |
There was a problem hiding this comment.
set_node erases the metadata, which is intentional here. This is probably wrong.
| end | ||
| }) | ||
|
|
||
| for stage = 1, 4 do |
There was a problem hiding this comment.
separate commit for this entire section, please
| effort. | ||
|
|
||
| The watering can can be made as follows: | ||
|
|
There was a problem hiding this comment.
Can you post some screenshots of how this looks in-game? The PNG's, obviously. Did you draw the images yourself?
| --[[ | ||
|
|
||
| Copyright (C) 2015 - Auke Kok <sofar@foo-projects.org> | ||
| 2018 - Marius Spix <marius.spix@web.de> |
There was a problem hiding this comment.
This is fine, but, you didn't claim or license the PNG files in the LICENSE file. This is required - make sure to document the origin of all the textures and choose an appropriate license (if it's the same license as the other images, perfect. If it's not, we can discuss)
|
What about this PR? Is this repo still actively maintained? |
|
There's open review comments that were asked to be addressed. If you need help or something in the comments isn't clear, feel free to ask. |
3 participants
This adds another crop, the eggfruit, and a new food item to this mod.