Skip to content

Revert preserve metadata #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-r wants to merge 2 commits into from
Closed

Revert preserve metadata #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51ece4d
Revert "Respect preserve_metadata when digging nodes"
j-r Aug 10, 2026
c358d03
Don't dig nodes with preserve_metadata
j-r Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions util.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ digtron.mark_diggable = function(pos, nodes_dug, player)
elseif (targetdef.diggable or targetdef.buildable_to) and
(targetdef.can_dig == nil or targetdef.can_dig(pos, player)) and
targetdef.on_dig == minetest.nodedef_default.on_dig and
not targetdef.preserve_metadata and
target.name ~= "air" then
nodes_dug:set(pos.x, pos.y, pos.z, true)
local in_known_group = false
Expand All @@ -94,16 +95,7 @@ digtron.mark_diggable = function(pos, nodes_dug, player)
end
end

local drops = minetest.get_node_drops(target.name, "")

if targetdef.preserve_metadata ~= nil then
local targetmeta = minetest.get_meta(pos):to_table()
-- preserve_metadata may modify all its parameters, but
-- we only care about the modified drops, anyway
targetdef.preserve_metadata(pos, target, targetmeta.fields, drops)
end

return material_cost, drops
return material_cost, minetest.get_node_drops(target.name, "")
end
return 0
end
Expand Down