Skip to content

support every paramtype2 #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

support every paramtype2 #662

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fae5db9
support every paramtype2
The4codeblocks May 2, 2025
328a5f3
Update sonic_screwdriver.lua
The4codeblocks May 3, 2025
56d818a
no power usage when no rotation + less magic numbers
The4codeblocks May 4, 2025
790ccf6
I mean here
The4codeblocks May 4, 2025
2268437
shut luacheck up
The4codeblocks May 4, 2025
5f8bb19
dedupe
The4codeblocks May 8, 2025
150e738
remove unused function
The4codeblocks May 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 60 additions & 14 deletions technic/tools/sonic_screwdriver.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,20 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)

local node = minetest.get_node(pos)
local ndef = minetest.registered_nodes[node.name]
if not ndef or not ndef.paramtype2 == "facedir" or
(ndef.drawtype == "nodebox" and
not ndef.node_box.type == "fixed") or
node.param2 == nil then

if not ndef then return end

local paramtype2 = ndef.paramtype2
if (
paramtype2 == nil or
paramtype2 == "color" or
paramtype2 == "meshoptions" or
paramtype2 == "leveled" or
paramtype2 == "flowingliquid" or
paramtype2 == "glasslikeliquidlevel" or
paramtype2 == "wallmounted" or
paramtype2 == "colorwallmounted"
) then
return
end

Expand All @@ -50,18 +60,54 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)
minetest.sound_play("technic_sonic_screwdriver", {pos = pos, gain = 0.3, max_hear_distance = 10})

-- Set param2
local rotationPart = node.param2 % 32 -- get first 4 bits
local preservePart = node.param2 - rotationPart

local axisdir = math.floor(rotationPart / 4)
local rotation = rotationPart - axisdir * 4
if mode == ROTATE_FACE then
rotationPart = axisdir * 4 + nextrange(rotation, 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

luacheck is yet unhappy technic/tools/sonic_screwdriver.lua:11:16: unused function nextrange
To fix that, you could ignore the warning (I hope it's the correct code) or remove the function.

-- luacheck: push ignore 211
local function foobar()
end
-- luacheck: pop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the function

done: 150e738

elseif mode == ROTATE_AXIS then
rotationPart = nextrange(axisdir, 5) * 4
local new_param2
local param2 = node.param2

local floor = math.floor
if (paramtype2 == "facedir") or (paramtype2 == "colorfacedir") then
local aux = floor(param2 / 32)
local rotation = param2 % 32

if mode == ROTATE_FACE then
rotation = (floor(param2 / 4)) * 4 + ((rotation + 1) % 4)
elseif mode == ROTATE_AXIS then
rotation = ((floor(param2 / 4) + 1) * 4) % 24
end

new_param2 = aux * 32 + rotation
elseif (paramtype2 == "4dir") or (paramtype2 == "color4dir") then
local aux = floor(param2 / 4)
local rotation = param2 % 4

if mode == ROTATE_FACE then
rotation = (rotation + 1) % 4
elseif mode == ROTATE_AXIS then
rotation = 0
end

new_param2 = aux * 4 + rotation
elseif (paramtype2 == "degrotate") then
if mode == ROTATE_FACE then
new_param2 = param2 + 1
elseif mode == ROTATE_AXIS then
new_param2 = param2 + 20
end
new_param2 = new_param2 % 240
elseif (paramtype2 == "colordegrotate") then
local aux = floor(param2 / 32)
local rotation = param2 % 32

if mode == ROTATE_FACE then
rotation = rotation + 1
elseif mode == ROTATE_AXIS then
rotation = rotation + 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I use paramtype2 = "degrotate", in the nodedef of "default:aspen_sapling" (nodes.lua), the rotation oddly jumps in this case. There is no such anomaly with paramtype2 = "degrotate",.
Is it because you're using modulo 32 in L94, but modulo 24 in L101?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

describe the jump
(%32 is bitwise extraction, %24 is rotation modulo)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I meant that colordegorate jumps oddly whereas degrotate works well.
It turns out this code is not flawed but my perception. It simply turned too far to notice at a stationary viewing position. When following the node around in its rotation, there is no such "glitch" or "jump".
Resolved.

end
rotation = rotation % 24

new_param2 = aux * 32 + rotation
end
Copy link
Member

@SmallJoker SmallJoker May 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: You could move this code up such that a final else case could be used for return. It would effectively deduplicate the lines L38-47.

Admittedly this code does not look great (magic numbers and many different cases) but I don't see much that could be done to improve it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be done


node.param2 = preservePart + rotationPart
node.param2 = new_param2
minetest.swap_node(pos, node)

if not technic.creative_mode then
Expand Down