Including SAP as a provider

[ajmaradiaga]

• Adding SAP provider configuration

• Adding resources of provider SAP

• Adding badge of SAP provider

• Adding SAP provider in the documentation

• Adding SAP ERP S4HANACloud

• Including additional SAP SaaS and ERP resources

• Removing resources with wrong name

• Updating BTP icons

• Refreshed icons

• Including new icons

• Including sample python scripts with new icons

• Updating icons for SAP Build Apps and Event Broker

• Including event broker

• Removing btp-diagrams-icons sample

• Incorporating latest icons

• Incorporate latest icons for AEM and SBPA

• Latest integration icons

• Syncing icons with the BTP solution diagrams structure

• Including SAP cleaner

---

[filipeaaoliveira]

Hey @gabriel-tessier @ajmaradiaga
This was a big one, so it took some time, but I tested it and everything seems correct from my side.

[ajmaradiaga]

@filipeaaoliveira @gabriel-tessier thanks for reviewing the PR. Unfortunately, a job failed because of a file that was incorrectly included in the repo. I removed tech-byte-diagram.py, which was included by mistake in the repository's root directory. This file caused a job run to fail: https://github.com/mingrammer/diagrams/actions/runs/15827106712/job/45501928915. It is not really needed hence why I just removed it in the last commit - 7be6f2f.

[ajmaradiaga]

@filipeaaoliveira @gabriel-tessier, I'm sorry this failed again. I ran the pre-commit hook locally and fixed the file causing the issue. This is another very minor fix.

[gabriel-tessier]

@ajmaradiaga
Thank you for the hard work and adding a new provider.
I was just worried about some icons I saw and wonder if they are ok?

There's a couple of icons like this one:
resources/sap/app_dev_automation/sap-build.png
which are blurry and hard to really describe the feature, it feel like a place holder than a real icon, maybe there's nothing but as I don't use SAP I'm not aware if it will really help the real SAP user to figure out the service.

There's other icons that are way too small like, they may not render well:
resources/sap/brands/sap-ariba.png
resources/sap/brands/sap-customer-experience.png

And other that are too big like which make the package more heavy:
resources/sap/brands/sap-leanix.png (954 x 200)

For the 2 first pattern maybe it need to rework and can be done later but if you can run a script and resize the big pictures to maximum 256, as stated in the contribution file here: https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

You should be able to ask some AI to build a script to run in the SAP directory and resize any pictures that is bigger than 256. Maybe can ask about up-scaling the small one too.

Thank you again for adding a new provider.

[gabriel-tessier]

I checked 514 files and only found one big picture and the SAP logo that is too small.

If it's not too much work it should be fine to address this 2 changes so we can merge the PR.
The 2 other pattern I listed are fine and should not block, forget about my previous comment to build a script to detect ad resize big pictures actually it should be done on our side when building the package, ensuring that the icons are not too big.

@ajmaradiaga
Thank you again for this monumental work.

@filipeaaoliveira
Thank you for the first review.

[gabriel-tessier]

Does this icon really describe the service for the end user? I'm not a SAP use so I cannot judge but if there's not yet icon it can be a good place holder at least to promote the service and maybe get future contribution.
This comment is not intended to blocking the merge it's just a comment, I think it' ok to merge.

[gabriel-tessier]

This file is way too small and will not render correctly, there's other provider that have the same problem with small problem, I just pinpoint this if somebody notice and may provide a better icon.
Here also this comment is not blocking.

[gabriel-tessier]

This icon is too big and can be reduce to fit the size defined in the contribution guide.
Please resize the icon to match the contribution guide.

[gabriel-tessier]

I'm sure this one have a better version that match the minimum size of 256

[zerodago]

Hi, any news ? I need Sap for my project.
Tks