Add Huaweicloud diagrams #741
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingrammer
added
kind/feat/provider
gabriel-tessier
requested changes
Jul 22, 2025
Collaborator
gabriel-tessier
left a comment
gabriel-tessier
left a comment
There was a problem hiding this comment.
Thank your for the contribution, here small changes that need to be done before merging.
Please put your provider at the end of the files as reported. It will help when merging to resolve conflicts.
Also if you can run again the autogen script the resources are not in the website directory.
Sorry for the long delay.
Collaborator
There was a problem hiding this comment.
Can you put the provider at the bottom of the lists/dicts, not in the middle.
Collaborator
There was a problem hiding this comment.
Can you put the cleaner method at the end, and define it at the end.
gabriel-tessier
requested review from
filipeaaoliveira,
gabriel-tessier,
mingrammer and
tvqphuoc01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Huawei cloud diagrams
disclaimer: although I am an employee of Huawei cloud, this project is not an official Huawei cloud product && is subject to changes