fix(storage): clamp non-positive entry query limits to the maximum#4469
Merged
Conversation
WithLimit ignored a zero limit, so /v1/entries?limit=0 produced a query without a SQL LIMIT and returned every matching entry, bypassing the 1000-entry cap. The official API client sends limit=0 for any filter with an unset Limit field, making unbounded queries easy to trigger. Clamp non-positive values to the maximum in both WithLimit and WithLimitAndMaximum so every caller (REST API, Google Reader) stays bounded, as intended by 0909323.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithLimitignored a zero limit, so/v1/entries?limit=0produced a query without a SQLLIMITand returned every matching entry, bypassing the 1000-entry cap. The official API client sendslimit=0for any filter with an unsetLimitfield, making unbounded queries easy to trigger.Clamp non-positive values to the maximum in both
WithLimitandWithLimitAndMaximumso every caller (REST API, Google Reader) stays bounded, as intended by 0909323.