fix(config): reject non-positive SCHEDULER_ENTRY_FREQUENCY_FACTOR values#4470
Merged
Merged
Conversation
SCHEDULER_ENTRY_FREQUENCY_FACTOR was the only scheduler option without a validator, so 0 was accepted at startup. With the entry_frequency polling scheduler, the factor is used as part of a divisor in ScheduleNextCheck, and a feed with weekly entries then triggered a division-by-zero panic inside a background worker, crashing the daemon. Require the factor to be >= 1, matching the validation of the other scheduler options, so the misconfiguration fails at startup instead.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCHEDULER_ENTRY_FREQUENCY_FACTORwas the only scheduler option without a validator, so0was accepted at startup. With theentry_frequencypolling scheduler, the factor is used as part of a divisor inScheduleNextCheck, and a feed with weekly entries then triggered a division-by-zero panic inside a background worker, crashing the daemon.Require the factor to be >= 1, matching the validation of the other scheduler options, so the misconfiguration fails at startup instead.