fix(worker): prevent panic when jobs are pushed during graceful shutdown#4472
Merged
Conversation
Pool.Shutdown() closed the job queue channel, but jobs can still be pushed while workers are draining: the feed scheduler ticker goroutine is never cancelled, and the UI and API refresh handlers push from detached goroutines that outlive the HTTP server shutdown. Any of them sending on the closed queue panicked the process mid-shutdown. Keep the queue channel open and instead close a dedicated shutdown channel, guarded by sync.Once. Push now selects between delivering a job and the shutdown signal, discarding jobs once shutdown begins, and workers select between the queue and the shutdown signal, so they still finish their current job before Shutdown returns.
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Jul 22, 2026
dsh2dsh
added a commit
to dsh2dsh/miniflux
that referenced
this pull request
Jul 22, 2026
Backport new tests from miniflux#4472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool.Shutdown()closed the job queue channel, but jobs can still be pushed while workers are draining: the feed scheduler ticker goroutine is never cancelled, and the UI and API refresh handlers push from detached goroutines that outlive the HTTP server shutdown. Any of them sending on the closed queue panicked the process mid-shutdown.Keep the queue channel open and instead close a dedicated shutdown channel, guarded by
sync.Once:Pushnow selects between delivering a job and the shutdown signal, discarding jobs once shutdown begins.Shutdownreturns.