MC updates for two releases. #1382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feorlen
reviewed
Dec 5, 2024
ravindk89
reviewed
Dec 5, 2024
Collaborator
ravindk89
left a comment
ravindk89
left a comment
There was a problem hiding this comment.
nits, mostly cleanup and not blockers.
ravindk89
approved these changes
Dec 6, 2024
| :optional: | ||
|
|
||
| Replay a previously saved JSON file. | ||
| Specify the path to the JSON file to replay, such as one generated by a previous run of this command. |
Collaborator
There was a problem hiding this comment.
I'll needle a bit more - does it always output a JSON file, or do you have to pipe the output?
Bradamant3
approved these changes
Dec 6, 2024
Collaborator
Bradamant3
left a comment
Bradamant3
left a comment
There was a problem hiding this comment.
lgtm although I wasn't one of the original requesters-of-changes. Also cannot miss this opportunity to lament accessibility issue of use of color. At least it's less around (and yes I realize this is not an issue for docs to fix ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1361
Closes #1371
Staging Info: