-
Notifications
You must be signed in to change notification settings - Fork 309
Fix UI issues #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI issues #1464
Conversation
rushenn
commented
May 2, 2025
- Toggle the docs menu conditionally to avoid showing empty white space when the menu is not present.

- Fix padding and layout shift when pasting into the search input field.

Thank you @rushenn ! Is there a way we can test these changes before they are merged? |
You can check out the PR and then build and serve locally.
Normal build thing.
(You may have to fiddle with the directory to serve from.) |
OH, uh ... I don't think we do have a way to turn off the menu. Duh. |
Thank you @djwfyi ! |
Well nothing breaks on build, so lets merge this and see what happens. |
Tested locally and agree with Ravind. |
Currently, the docs menu is populated based on the array defined in
The idea here is that if docs is empty or missing, the menu will not be displayed. |
Yeah, that's the section I commented out to test it. Thanks for the work! |