Skip to content

Fix UI issues #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025
Merged

Fix UI issues #1464

merged 2 commits into from
May 2, 2025

Conversation

rushenn
Copy link
Member

@rushenn rushenn commented May 2, 2025

  1. Toggle the docs menu conditionally to avoid showing empty white space when the menu is not present.
Screenshot 2025-05-02 at 10 41 07 AM
  1. Fix padding and layout shift when pasting into the search input field.
Screenshot 2025-05-02 at 10 42 28 AM

@rushenn rushenn requested review from ravindk89, djwfyi and feorlen May 2, 2025 05:13
@feorlen
Copy link
Collaborator

feorlen commented May 2, 2025

Thank you @rushenn ! Is there a way we can test these changes before they are merged?

@djwfyi
Copy link
Collaborator

djwfyi commented May 2, 2025

@feorlen

Thank you @rushenn ! Is there a way we can test these changes before they are merged?

You can check out the PR and then build and serve locally.

gh pr checkout 1464

Normal build thing.

python3 -m http.server --directory build/ui-fix/linux/html

(You may have to fiddle with the directory to serve from.)

@djwfyi
Copy link
Collaborator

djwfyi commented May 2, 2025

OH, uh ... I don't think we do have a way to turn off the menu. Duh.

@feorlen
Copy link
Collaborator

feorlen commented May 2, 2025

Thank you @djwfyi !

@ravindk89
Copy link
Collaborator

Well nothing breaks on build, so lets merge this and see what happens.

@ravindk89 ravindk89 merged commit 1fc3907 into minio:main May 2, 2025
1 check passed
@djwfyi
Copy link
Collaborator

djwfyi commented May 2, 2025

Tested locally and agree with Ravind.

@rushenn
Copy link
Member Author

rushenn commented May 3, 2025

@djwfyi

OH, uh ... I don't think we do have a way to turn off the menu. Duh.

Currently, the docs menu is populated based on the array defined in default.conf.py

html_context = {
   'doc_platform': platform.lower(),
   'docs': [
      # The first item has to be the current docs site #
      {
         'name': 'MinIO Server',
         'current': True
      },
      {
         'name': 'DirectPV',
         'url': 'https://min.io/docs/directpv',
         'external': True
      },
      {
         'name': 'KES',
         'url': 'https://min.io/docs/kes',
         'external': True
      }
   ]
}

The idea here is that if docs is empty or missing, the menu will not be displayed.

@djwfyi
Copy link
Collaborator

djwfyi commented May 3, 2025

Yeah, that's the section I commented out to test it. Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants