feat: add GetBucketType API for replication target validation #2195
Conversation
why do we need this API? @csumisha |
@harshavardhana Should throw validation error when trying to add a table warehouse bucket as a replication target bucket. https://github.com/miniohq/eos/pull/2717 |
Add GetBucketType() method to query bucket type via the ?bucket-type S3 extension endpoint. This allows validating replication targets to prevent setting warehouse buckets as replication destinations.
csumisha
force-pushed
the
bucket-type-api
branch
from
eed9156 to
be693a5
Compare
|
yes but why do we need this new API and exposed via minio-go? |
|
@harshavardhana It is using HeadBucket - I guess we don't have that as a standalone function, but rather a bunch of different calls. |
|
@harshavardhana as @klauspost mentioned there is no standalone head function, what is your recommendation here? |
csumisha
force-pushed
the
bucket-type-api
branch
2 times, most recently
from
53f85f9 to
5b9dc0e
Compare
Add HeadBucket method that performs HEAD request on bucket and returns HeadBucketInfo struct with bucket metadata from response headers. Includes Type field for MinIO bucket type extension (standard/warehouse).
csumisha
force-pushed
the
bucket-type-api
branch
from
5b9dc0e to
337f7c3
Compare
|
Not required, handled it differently https://github.com/miniohq/eos/pull/2717 |
4 participants
Add GetBucketType() method to query bucket type via the ?bucket-type S3 extension endpoint. This allows validating replication targets to prevent setting warehouse buckets as replication destinations.