Fix object ReadAt performs seek #2197
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [io.ReaderAt](https://pkg.go.dev/io#ReaderAt) docs states... > If ReadAt is reading from an input source with a seek offset, ReadAt should not affect nor be affected by the underlying seek offset. We did not satisfy that constraint and Read would be affected by the ReadAt. Since the ReadAt would only request the part of the object relevant for the ReadAt we shouldn't risk anyone relying on this feature since it would always have errored out before.
marktheunissen
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The io.ReaderAt docs states...
We did not satisfy that constraint and Read would be affected by the ReadAt.
Since the ReadAt would only request the part of the object relevant for the ReadAt we shouldn't risk anyone relying on this feature since it would always have errored out before.
Fixes #2196