Skip to content

feat: add --key-password flag to decrypt Certs key #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harshavardhana merged 6 commits into from
Mar 6, 2025
Merged

feat: add --key-password flag to decrypt Certs key #125

harshavardhana merged 6 commits into from
Mar 6, 2025

Conversation

@jiuker
Copy link
Contributor

@jiuker jiuker commented Mar 6, 2025

feat: add --key-password flag to decrypt Certs key

feat: add --key-password flag to decrypt Certs key
cdac78e 
feat: add --key-password flag to decrypt Certs key
jiuker added 2 commits March 6, 2025 11:42
nolint
e88e8bd 
nolint
update go version
da89681 
update go version
harshavardhana
harshavardhana requested changes Mar 6, 2025
View reviewed changes
update go mod
6524ceb 
update go mod
@jiuker jiuker requested a review from harshavardhana March 6, 2025 03:54
@shtripat
Copy link
Contributor

shtripat commented Mar 6, 2025

I am trying to understand how the name --key-password aligns with decryption of certs keys. Shouldn't this be called --decrypt-cert-keys or --decrypt-keys

@jiuker
Copy link
Contributor Author

jiuker commented Mar 6, 2025

I am trying to understand how the name --key-password aligns with decryption of certs keys. Shouldn't this be called --decrypt-cert-keys or --decrypt-keys

Now certs flags is --key, --cert, and then @harshavardhana suggest that name @shtripat

shtripat
shtripat reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One small suggestion.

message
8477efb 
message
@jiuker jiuker requested a review from shtripat March 6, 2025 09:11
shtripat
shtripat approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

harshavardhana
harshavardhana requested changes Mar 6, 2025
View reviewed changes
@harshavardhana harshavardhana merged commit 958ab08 into minio:master Mar 6, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadmeste vadmeste vadmeste approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@shtripat shtripat shtripat approved these changes

@poornas poornas Awaiting requested review from poornas

@klauspost klauspost Awaiting requested review from klauspost

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiuker @shtripat @vadmeste @harshavardhana