Skip to content

Pre-populate assessment justification on PQA submission#1143

Merged
Carl Sixsmith (carlsixsmith-moj) merged 2 commits into
release/v2026.06.22from
CFODEV-1149-Populate-Previous-RAG-Justificaiton
Jun 25, 2026
Merged

Pre-populate assessment justification on PQA submission#1143
Carl Sixsmith (carlsixsmith-moj) merged 2 commits into
release/v2026.06.22from
CFODEV-1149-Populate-Previous-RAG-Justificaiton

Conversation

@PaulCooperWorkJustice

Copy link
Copy Markdown
Contributor

Add functionality to retrieve and pre-populate the previous assessment justification when submitting a case to Provider QA, allowing users to review and edit their previous justification rather than re-typing.

Changes:

  • Add GetPreviousJustification query to retrieve participant assessment justification
  • Enhance ConfirmationWithNotesDialog to accept and display previous justification
  • Update SubmitToPqa workflow to fetch and pass previous justification when required
  • Improve code consistency (default! → null!, add @ prefixes, method visibility)

🔗 Related Work

  • Closes: #
  • Related: #

📌 Summary

What does this PR do? Keep it short but clear.


🎯 Purpose / Motivation

Why does this change exist? What problem are we solving?


🧠 Approach

Key implementation details, trade-offs, or design decisions.
Mention anything reviewers should pay attention to.


🔄 Changes

  • Added:
  • Updated:
  • Removed:

🧪 How to Test

Step-by-step instructions to verify this works.

Expected result:

What should happen if everything is correct?


📸 Screenshots / Output (if applicable)

UI changes, logs, API responses, etc.


⚠️ Risks & Impact

  • Breaking change
  • Database change
  • Performance impact
  • Security impact

Details:

Anything reviewers should be cautious about.


🙋 Notes for Reviewers

Anything specific you want feedback on.
e.g. "Unsure about approach in X", "Focus on Y logic"

@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) changed the title feat: pre-populate assessment justification on PQA submission Pre-populate assessment justification on PQA submission Jun 17, 2026
@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) added Needs Review This pull request is awaiting review Bug Fix labels Jun 18, 2026
@vks333 Vinay Saini (vks333) self-requested a review June 18, 2026 11:59

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The justification can be added to the summary dto and remove the need for a specific call to get it.

This data can then be used elsewhere (for example giving the case owner visibility of it as it disappears outside of QA process)

@carlsixsmith-moj Carl Sixsmith (carlsixsmith-moj) added Changes Requested Changes have been requested for this pull request and removed Needs Review This pull request is awaiting review labels Jun 21, 2026
Add functionality to retrieve and pre-populate the previous assessment
justification when submitting a case to Provider QA, allowing users to
review and edit their previous justification rather than re-typing.

Changes:
- Add GetPreviousJustification query to retrieve participant assessment justification
- Enhance ConfirmationWithNotesDialog to accept and display previous justification
- Update SubmitToPqa workflow to fetch and pass previous justification when required
- Improve code consistency (default! → null!, add @ prefixes, method visibility)

Signed-off-by: Paul Cooper <Paul.Cooper5@Justice.gov.uk>
@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) force-pushed the CFODEV-1149-Populate-Previous-RAG-Justificaiton branch from cd3e837 to c2f90da Compare June 22, 2026 14:51
- Add AssessmentJustification to ParticipantSummaryDto and map from participant entity
- Remove redundant GetPreviousJustification query and database roundtrip
- Convert DTO properties from 'set' to 'init' for immutability
- Update ParticipantActionMenu to use justification from summary DTO
- Fix typos in XML documentation comments

Signed-off-by: Paul Cooper <Paul.Cooper5@Justice.gov.uk>
@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) force-pushed the CFODEV-1149-Populate-Previous-RAG-Justificaiton branch from 80d72bf to aacac8e Compare June 23, 2026 10:11
@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) changed the base branch from develop to release/v2026.06.22 June 23, 2026 10:12
@PaulCooperWorkJustice

Copy link
Copy Markdown
Contributor Author

The justification can be added to the summary dto and remove the need for a specific call to get it.

This data can then be used elsewhere (for example giving the case owner visibility of it as it disappears outside of QA process)

I've changed it so assessment justification is now on participantDTO as asked for

@PaulCooperWorkJustice Paul Cooper (PaulCooperWorkJustice) added Needs Review This pull request is awaiting review and removed Changes Requested Changes have been requested for this pull request labels Jun 23, 2026
@carlsixsmith-moj Carl Sixsmith (carlsixsmith-moj) merged commit 96f58ad into release/v2026.06.22 Jun 25, 2026
@carlsixsmith-moj Carl Sixsmith (carlsixsmith-moj) deleted the CFODEV-1149-Populate-Previous-RAG-Justificaiton branch June 25, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Needs Review This pull request is awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants