Skip to content

Bump metadata-presenter for govuk crest#2776

Merged
Hettie Street (HettieS) merged 4 commits into
mainfrom
testable-bump-metadata-presenter-version
Apr 23, 2025
Merged

Bump metadata-presenter for govuk crest#2776
Hettie Street (HettieS) merged 4 commits into
mainfrom
testable-bump-metadata-presenter-version

Conversation

@HettieS
Copy link
Copy Markdown
Contributor

No description provided.

@HettieS Hettie Street (HettieS) requested a review from a team as a code owner April 22, 2025 13:54
MeenaModhvadia
MeenaModhvadia previously approved these changes Apr 23, 2025
Copy link
Copy Markdown

@MeenaModhvadia MeenaModhvadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - bumping up versions and branch name amended to new crest branch.

Copy link
Copy Markdown

@MeenaModhvadia MeenaModhvadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - adding sleeps to allow extra time for tests to complete

@HettieS
Copy link
Copy Markdown
Contributor Author

LGTM - bumping up versions and branch name amended to new crest branch.

MeenaModhvadia yes that's right, we set the version of the metadata data presenter to be the one with the updated crest. The preview section inside the editor can then access the new crest. I had to add some additional CSS styling to the editor to work in conjuction with the metadata presenter code.

I think the branch renaming you're referring to is where I pointed the editor to a test branch version of the metadata presenter - I did this to diagnose some issues. That code is commented out because it is only for testing purposes.

@HettieS Hettie Street (HettieS) merged commit 0358093 into main Apr 23, 2025
14 checks passed
@HettieS Hettie Street (HettieS) deleted the testable-bump-metadata-presenter-version branch April 23, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants