Skip to content

CDPTKAN-763: Software updates: rubocop-govuk #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ripan (ripan) merged 3 commits into from
May 6, 2026
Merged

CDPTKAN-763: Software updates: rubocop-govuk #2935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
987699d
Update rubocop-govuk
ripan May 5, 2026
3cc6f39
Update date_validation.rb
ripan May 5, 2026
df7fb97
Merge branch 'main' into CDPTKAN-763-software-updates-rubocop-govuk
ripan May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ group :development do
gem 'binding_of_caller'
gem 'listen', '~> 3.8'
gem 'rubocop'
gem 'rubocop-govuk'
gem 'rubocop-govuk', '~> 5.1.1'
gem 'ruby-lsp'
gem 'spring'
gem 'spring-watcher-listen', '~> 2.1.0'
Expand Down
31 changes: 16 additions & 15 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ GEM
ostruct (0.6.1)
pagy (6.5.0)
parallel (1.26.3)
parser (3.3.7.1)
parser (3.3.11.1)
ast (~> 2.4.1)
racc
pg (1.5.9)
Expand Down Expand Up @@ -675,39 +675,40 @@ GEM
rspec-support (3.13.2)
rspec_junit_formatter (0.6.0)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.74.0)
rubocop (1.79.2)
json (~> 2.3)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.1.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.9.3, < 3.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop-ast (>= 1.46.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 4.0)
rubocop-ast (1.39.0)
parser (>= 3.3.1.0)
rubocop-ast (1.46.0)
parser (>= 3.3.7.2)
prism (~> 1.4)
rubocop-capybara (2.22.1)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
rubocop-govuk (5.1.0)
rubocop (= 1.74.0)
rubocop-ast (= 1.39.0)
rubocop-govuk (5.1.20)
rubocop (= 1.79.2)
rubocop-ast (= 1.46.0)
rubocop-capybara (= 2.22.1)
rubocop-rails (= 2.30.3)
rubocop-rails (= 2.33.3)
rubocop-rake (= 0.7.1)
rubocop-rspec (= 3.5.0)
rubocop-rails (2.30.3)
rubocop-rspec (= 3.6.0)
rubocop-rails (2.33.3)
activesupport (>= 4.2.0)
lint_roller (~> 1.1)
rack (>= 1.1)
rubocop (>= 1.72.1, < 2.0)
rubocop-ast (>= 1.38.0, < 2.0)
rubocop (>= 1.75.0, < 2.0)
rubocop-ast (>= 1.44.0, < 2.0)
rubocop-rake (0.7.1)
lint_roller (~> 1.1)
rubocop (>= 1.72.1)
rubocop-rspec (3.5.0)
rubocop-rspec (3.6.0)
lint_roller (~> 1.1)
rubocop (~> 1.72, >= 1.72.1)
ruby-lsp (0.26.9)
Expand Down Expand Up @@ -872,7 +873,7 @@ DEPENDENCIES
rspec-rails
rspec_junit_formatter
rubocop
rubocop-govuk
rubocop-govuk (~> 5.1.1)
ruby-lsp
sass-rails (>= 6)
selenium-webdriver (= 4.15.0)
Expand Down
2 changes: 1 addition & 1 deletion app/models/component_validations/date_validation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class DateValidation < BaseComponentValidation
validates_with DateValidator, if: :run_validation?

def run_validation?
enabled? && (day.present? && month.present? && year.present?)
enabled? && (day.present? && month.present? && year.present?) # rubocop:disable Style/RedundantParentheses
end

def answered_day
Expand Down
Loading